Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve user-facing network error message when requesting indexes #8738

Closed
wants to merge 6 commits into from
Closed

Improve user-facing network error message when requesting indexes #8738

wants to merge 6 commits into from

Commits on Aug 9, 2020

  1. Clean up indentation a bit

    @uranusjr
    uranusjr committed Aug 9, 2020
    Configuration menu
    Copy the full SHA
    df46861 View commit details
    Browse the repository at this point in the history

  2. Rename NetworkConnectionError 

    There are way too many exceptions that say "connection". Rename this
class so it's clear the exception is generated from an HTTP response,
not during connection.
    @uranusjr
    uranusjr committed Aug 9, 2020
    Configuration menu
    Copy the full SHA
    4db6d46 View commit details
    Browse the repository at this point in the history

  3. Make decoding functions more robust

    @uranusjr
    uranusjr committed Aug 9, 2020
    Configuration menu
    Copy the full SHA
    102fb0a View commit details
    Browse the repository at this point in the history

  4. Output a warning when an HTTP page fails to load 

    This creates a message that the user can see. We will flesh out this
message to include better explainations for each situation in later
commits.
    @uranusjr
    uranusjr committed Aug 9, 2020
    Configuration menu
    Copy the full SHA
    2f6e82f View commit details
    Browse the repository at this point in the history

  5. Pass in more structured context into exception 

    This may help us provide better error messages if needed, instead of
being stuck with an eagerly-rendered string.
    @uranusjr
    uranusjr committed Aug 9, 2020
    Configuration menu
    Copy the full SHA
    bc37c60 View commit details
    Browse the repository at this point in the history

  6. Add block to catch connection and proxy errors 

    This allows us to output a more specific error message to help users in
common cases.
    @uranusjr
    uranusjr committed Aug 9, 2020
    Configuration menu
    Copy the full SHA
    f3a04ac View commit details
    Browse the repository at this point in the history