Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Pipfile.lock from the repository #514

Closed
uranusjr opened this issue Sep 10, 2017 · 2 comments
Closed

Exclude Pipfile.lock from the repository #514

uranusjr opened this issue Sep 10, 2017 · 2 comments

Comments

@uranusjr
Copy link
Member

Reading #501 makes me wonder whether it is a good idea to check in Pipfile.lock for this particular project (Pipenv). Reading discussions about other similar tools (SO entry on Bundler) it seems it is generally recommended to include the lock file if you want everyone to work on the same dependencies (e.g. developing an application), but exclude if you intend to support various versions of dependencies (e.g. developing a library). Now that #295 is implemented it feels even more wrong checking in the lock file and tracking irrelevant changes all the time.

Another thing worth discussing is whether it makes sense to check in Pipfile.lock at all. I want identical dependency versions, but don’t usually care about host OS, and it feels wrong that the lock file changes all the time when I work on a Django website on two machines, one Mac and one Windows. Either I’m doing it wrong, or there should be some switches to mark whether a project is platform-specific, Python version-specific (the intention of #295 I think), etc.

@kennethreitz
Copy link
Contributor

lockfiles are generally encouraged to be included in source control, for applications.

For us, it might not make sense. But, it's a learning experience, so we're doing it for now. I may remove it.

The system information is there just as meta-data.

@kennethreitz
Copy link
Contributor

Exlcuded lock from out repo.

dochang added a commit to dochang/bumplus that referenced this issue Feb 25, 2018
See [1] & [2] for details

[1]: pypa/pipenv@ab20b51
[2]: pypa/pipenv#514
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants