Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run flake8 static checks separately from test suite #147

Merged
merged 2 commits into from
Aug 2, 2022
Merged

Run flake8 static checks separately from test suite #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
884e0ed
Run style checks separate from test suite
takluyver Aug 2, 2022
a29513a
Don't use --flake8 option for pytest
takluyver Aug 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ env:
FORCE_COLOR: 1

jobs:
isort:
static-checks:
runs-on: ubuntu-latest

steps:
Expand All @@ -23,7 +23,7 @@ jobs:
pip install tox tox-venv

- name: Run tests
run: tox -e isort
run: tox -e isort,flake8

tests:
runs-on: ${{ matrix.os }}
Expand Down
1 change: 0 additions & 1 deletion dev-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
pytest
pytest-flake8
flake8
testpath
tomli
Expand Down
3 changes: 0 additions & 3 deletions pytest.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,7 @@
addopts =
--strict-config
--strict-markers
--flake8
xfail_strict = True
junit_family = xunit2
filterwarnings =
error
# Suppress deprecation warning in flake8
ignore:SelectableGroups dict interface is deprecated::flake8
4 changes: 4 additions & 0 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ commands = pytest []
deps = isort
commands = python -m isort --check --diff {toxinidir}

[testenv:flake8]
deps = flake8
commands = flake8 pep517

[testenv:release]
skip_install = True
deps =
Expand Down