Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run flake8 static checks separately from test suite #147

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

takluyver
Copy link
Member

pytest-flake8 is a compatibility headache - see tholo/pytest-flake8#81 tholo/pytest-flake8#83 & tholo/pytest-flake8#87 . The advantages of running it inside pytest seem small at best, so this gets rid of the pytest integration in favour of running flake8 directly. In the CI, isort & flake8 are run as part of a 'static-checks' job.

@takluyver
Copy link
Member Author

To be clear, I'm not trying to criticise the developers of pytest-flake8 - I think compatibility headaches are probably unavoidable. Flake8 is pretty clear that it's an application, not a library, and plugin APIs (it's a pytest plugin) are always difficult, because eventually the application developers are going to have a choice between slightly breaking a plugin API and holding back the application development.

I'm going to merge this since one of those compatibility issues is currently causing the CI to fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant