Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate release workflow #3114

Closed
wants to merge 4 commits into from
Closed

Conversation

blink1073
Copy link
Contributor

@blink1073 blink1073 commented Feb 16, 2022

Summary of changes

Adds an extra discriminator for ${{ github.ref }} in the concurrency group.
This avoids a race condition in workflow runs which caused the release job to be canceled for either a tag or a commit with the same sha.

Part of #3093

Pull Request Checklist

@abravalheri
Copy link
Contributor

Hi @blink1073 thank you very much for providing this PR!

I was trying to go through GitHub's docs trying to understand this config with release: types: [published].

Does this solve the problem with tests never running discussed in #3093 (comment)?

@blink1073
Copy link
Contributor Author

The latest commit effectively restores the original behavior before concurrency limiting as much as possible. The only difference is that we don't run the unit tests explicitly before release.

@abravalheri
Copy link
Contributor

I was not expecting how more annoying PyPy+Windows tests can be...
It is like they are just waiting to fail in different ways...

@blink1073
Copy link
Contributor Author

Yeah, it is pain squared

@blink1073
Copy link
Contributor Author

Okay, with the latest change I believe we have what we want. We avoid canceling subsequent pushes and pushes that are to different git references, refs/head/main vs refs/tags/foo.

@blink1073
Copy link
Contributor Author

Closing in favor of #3116

@blink1073 blink1073 closed this Feb 17, 2022
@blink1073 blink1073 deleted the add-release-job branch February 17, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants