Tweak concurrency group for CI so tag is not cancelled by push
#3116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abravalheri
changed the title
tags are not cancelled by pushestag is not cancelled by push
|
@jaraco, this might help with the problem in #3093 (comment), although I guess the only way of testing it is to apply to the repository and see what happens next time a release is cut. |
|
Oh ha, I didn't see this PR before I updated mine. I think this is probably cleaner. |
|
@blink1073, thank you very much for the help! Should we close one of the 2 PRs now that they are mostly the same? I don't mind which one, so please let me know which one you prefer :) |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to prevent the
releasejob from being cancelled.The problem was described in #3097 (comment) and #3093 (comment).
Summary of changes
Add
github.ref_typeto theconcurrency.groupAccording to the docs
github.ref_typecan be eithertagorbranch, so my hope is that it should differentiate between a push to main and a new tag, but I don't know how to test that...The drawback of this change is that the CI workflow will run twice for the commit being tagged (but I think that is not problematic, giving that tags are only created sporadically and the number of duplication will be very small)
Closes
Pull Request Checklist
changelog.d/.(See documentation for details)