Merges develop into release (1.17.0 tag prep)

[kbwestfall]

As titled.

Please approve, but let me perform the merge.

[kbwestfall]

dev-suite is running.

[rcooke-ast]

Here's one approval!

[kbwestfall]

Tests pass:

Test Summary
--------------------------------------------------------
--- PYTEST PYPEIT UNIT TESTS PASSED  257 passed, 6569 warnings in 628.88s (0:10:28) ---
--- PYTEST UNIT TESTS PASSED  152 passed, 2669 warnings in 1122.08s (0:18:42) ---
--- PYTEST VET TESTS PASSED  62 passed, 106524 warnings in 6083.04s (1:41:23) ---
--- PYPEIT DEVELOPMENT SUITE PASSED 247/247 TESTS  ---
Testing Started at 2024-10-31T15:28:56.750347
Testing Completed at 2024-11-01T13:31:23.402582
Total Time: 22:02:26.652235

[kbwestfall]

Just a heads up that I'm running the dev-suite again. We had forgotten to exclude the pixelflat files from the distribution (see the change to MANIFEST.in), and it's worth making sure the wheel installation still works.

[kbwestfall]

I'm not getting a vet-test failure that I didn't get before:

FAILED ../PypeIt-development-suite/vet_tests/test_datacube.py::test_coadd_datacube - AssertionError: assert np.float64(2.1362524897048756) < (0.1 * np.float64(3...
========== 1 failed, 61 passed, 106524 warnings in 6129.61s (1:42:09) ==========

Test Summary
--------------------------------------------------------
--- PYTEST PYPEIT UNIT TESTS PASSED  257 passed, 6569 warnings in 613.41s (0:10:13) ---
--- PYTEST UNIT TESTS PASSED  152 passed, 2669 warnings in 1128.68s (0:18:48) ---
--- PYTEST VET TESTS FAILED  1 failed, 61 passed, 106524 warnings in 6129.61s (1:42:09) ---
--- PYPEIT DEVELOPMENT SUITE PASSED 247/247 TESTS  ---
Testing Started at 2024-11-01T17:31:28.383990
Testing Completed at 2024-11-02T14:29:13.375801
Total Time: 20:57:44.991811

The failure is from this line: https://github.com/pypeit/PypeIt-development-suite/blob/0528bd407f2eb9dd5f6272584911274af28845bb/vet_tests/test_datacube.py#L139

@rcooke-ast , any ideas? This test didn't fail earlier, and nothing in the code should have changed to cause it to fail. Is there any variability you can think of in terms of the success of the code?

[profxj]

approved!