-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump pyjwt[crypto] from 2.8.0 to 2.9.0 #16378
Conversation
06046b6
to
dfe8781
Compare
Failure: ___________ TestPyJWTBackstop.test_decodes_token_typeerror_on_pyjwk ____________
[gw0] linux -- Python 3.12.4 /opt/warehouse/bin/python
self = <tests.unit.oidc.test_services.TestPyJWTBackstop object at 0xffd08f7fc1d0>
def test_decodes_token_typeerror_on_pyjwk(self):
privkey_jwk = PyJWK.from_json(algorithms.RSAAlgorithm.to_jwk(self._privkey))
pubkey_jwk = PyJWK.from_json(algorithms.RSAAlgorithm.to_jwk(self._pubkey))
token = jwt.encode({"foo": "bar"}, privkey_jwk.key, algorithm="RS256")
# Passing a `PyJWK` directly into `jwt.decode` does not work.
> with pytest.raises(TypeError, match=r"Expecting a PEM-formatted key\."):
E Failed: DID NOT RAISE <class 'TypeError'>
tests/unit/oidc/test_services.py:[98](https://github.com/pypi/warehouse/actions/runs/10056636776/job/27795874529?pr=16239#step:5:99)2: Failed Looks like the upstream enabled passing PyJWK now. Refs: jpadilla/pyjwt#886 @woodruffw Should we be able to update the tests to allow passing a PyJWK now that the underlying library allows for it? |
Yep! That test is a backstop to allow us to catch when this behavior changed, which we expected it to 🙂 -- we can now invert that test IMO. |
@dependabot rebase |
Bumps [pyjwt[crypto]](https://github.com/jpadilla/pyjwt) from 2.8.0 to 2.9.0. - [Release notes](https://github.com/jpadilla/pyjwt/releases) - [Changelog](https://github.com/jpadilla/pyjwt/blob/master/CHANGELOG.rst) - [Commits](jpadilla/pyjwt@2.8.0...2.9.0) --- updated-dependencies: - dependency-name: pyjwt[crypto] dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dfe8781
to
ac97960
Compare
As updated in jpadilla/pyjwt#886 Signed-off-by: Mike Fiedler <miketheman@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Bumps pyjwt[crypto] from 2.8.0 to 2.9.0.
Release notes
Sourced from pyjwt[crypto]'s releases.
Changelog
Sourced from pyjwt[crypto]'s changelog.
Commits
868cf4a
Add 2.9.0 changelog. Fixes #949 (#967)304a3df
[pre-commit.ci] pre-commit autoupdate (#965)527fec2
Raise exception when required cryptography dependency is missing (#963)18a50be
[pre-commit.ci] pre-commit autoupdate (#960)4703f87
Handle load_pem_public_key ValueError (#952)9dc732f
Update usage.rst (#958)ab8176a
Decode with PyJWK (#886)c0a071d
chore: update actions/download-artifact2afbe32
Add coverage and improve performance of is_ssh_key (#940)97345a7
[pre-commit.ci] pre-commit autoupdate (#953)You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)