Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Copy/Paste state - Viewport position" tool improvements #722

Conversation

melnikovalex
Copy link
Contributor

@melnikovalex melnikovalex commented Oct 14, 2019

Hey Ehsan,
Hey Gui

I've got several feedbacks on "Copy/Paste state - Copy viewport position" tool from my colleagues.
So am trying to make it work better in certain cases (but the work is still in progress)

Therefore I think it would be great if @gtalarico would have a look as well.

Please, let me know if I can break something or if I shouldn't touch it at all.

  • support Sheets with different TitleBlock locations

  • hide viewport on a sheet when getting a cropbox

  • allow to choose ProjectBasePoint as origin (instead of Cropbox)

  • show the option "By ProjectBasePoint" only if possible

  • allow to choose cropbox alignment (top left, bottom left etc.) (optional, with shiftclick?)

  • support Sections/Elevation views (by project base point)

  • support active view (not selected viewport)

  • support Pasting to multiple selected elements at once (relevant for all Copy/Paste modes)

Thank you too

@@ -0,0 +1,179 @@
from pyrevit import revit, script, forms, DB
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved all methods which are used both in Copy and Paste scripts to separated script in lib

@eirannejad eirannejad closed this Nov 7, 2019
@eirannejad eirannejad self-assigned this Nov 8, 2019
@eirannejad eirannejad reopened this Nov 8, 2019
@eirannejad eirannejad changed the base branch from release/4.7.3-beta4 to pr/722 November 8, 2019 21:20
@eirannejad eirannejad removed their assignment Nov 8, 2019
@melnikovalex
Copy link
Contributor Author

Closed, because I rewrote this in another way in #763

@eirannejad
Copy link
Collaborator

@melnikovalex Thanks a lot. I'm going thru job change but will merge these soon

eirannejad added a commit that referenced this pull request Dec 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants