Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Copy/Paste state - Viewport position" tool improvements #722

Closed
wants to merge 4 commits into from
Closed

"Copy/Paste state - Viewport position" tool improvements #722

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d41f037
DRY-principle optimization
melnikovalex Oct 11, 2019
ab48817
Reduce redundant methods
melnikovalex Oct 11, 2019
4b5d288
Support sheets with shifted title block location
melnikovalex Oct 14, 2019
b2fca81
Copy viewport position by Project Base Point
melnikovalex Oct 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
218 changes: 33 additions & 185 deletions ...vitTools.extension/pyRevit.tab/Selection.panel/memo.stack/Copy State.pushbutton/script.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,19 @@
import os
import os.path as op
import pickle

from pyrevit import HOST_APP
from pyrevit.framework import List
from pyrevit import revit, DB, UI

from pyrevit import revit, DB
from pyrevit import forms
from pyrevit import script

import viewport_placement_utils as vpu

__doc__ = 'Copies the state of desired parameter of the active'\
' view to memory. e.g. Visibility Graphics settings or'\
' Zoom state. Run it and see how it works.'

__authors__ = ['Gui Talarico', '{{author}}']


class Point:
def __init__(self, x, y, z):
self.x = x
self.y = y
self.z = z
logger = script.get_logger()


class BasePoint:
Expand All @@ -29,37 +22,6 @@ def __init__(self):
self.y = 0


class BBox:
def __init__(self):
self.minx = 0
self.miny = 0
self.minz = 0
self.maxx = 0
self.maxy = 0
self.maxz = 0


class ViewOrient:
def __init__(self):
self.eyex = 0
self.eyey = 0
self.eyez = 0
self.forwardx = 0
self.forwardy = 0
self.forwardz = 0
self.upx = 0
self.upy = 0
self.upz = 0


class TransformationMatrix:
def __init__(self):
self.sourcemin = None
self.sourcemax = None
self.destmin = None
self.destmax = None


def make_picklable_list(curve_loops):
all_cloops = []
for curve_loop in curve_loops:
Expand Down Expand Up @@ -120,15 +82,15 @@ def make_picklable_list(curve_loops):
sb = av.GetSectionBox()
viewOrientation = av.GetOrientation()

sbox = BBox()
sbox = vpu.BBox()
sbox.minx = sb.Min.X
sbox.miny = sb.Min.Y
sbox.minz = sb.Min.Z
sbox.maxx = sb.Max.X
sbox.maxy = sb.Max.Y
sbox.maxz = sb.Max.Z

vo = ViewOrient()
vo = vpu.ViewOrient()
vo.eyex = viewOrientation.EyePosition.X
vo.eyey = viewOrientation.EyePosition.Y
vo.eyez = viewOrientation.EyePosition.Z
Expand Down Expand Up @@ -158,159 +120,45 @@ def make_picklable_list(curve_loops):
pyrevit Notice:
pyrevit: repository at https://github.com/eirannejad/pyrevit
"""
vport = vpu.select_viewport()

originalviewtype = ''

selview = selvp = None
vpboundaryoffset = 0.01
activeSheet = revit.active_view
transmatrix = TransformationMatrix()
revtransmatrix = TransformationMatrix()

def sheet_to_view_transform(sheetcoord):
global transmatrix
newx = \
transmatrix.destmin.X \
+ (((sheetcoord.X - transmatrix.sourcemin.X)
* (transmatrix.destmax.X - transmatrix.destmin.X))
/ (transmatrix.sourcemax.X - transmatrix.sourcemin.X))

newy = \
transmatrix.destmin.Y \
+ (((sheetcoord.Y - transmatrix.sourcemin.Y)
* (transmatrix.destmax.Y - transmatrix.destmin.Y))
/ (transmatrix.sourcemax.Y - transmatrix.sourcemin.Y))

return DB.XYZ(newx, newy, 0.0)

def set_tansform_matrix(selvp, selview):
# making sure the cropbox is active.
cboxactive = selview.CropBoxActive
cboxvisible = selview.CropBoxVisible
cboxannoparam = selview.get_Parameter(
DB.BuiltInParameter.VIEWER_ANNOTATION_CROP_ACTIVE
)

cboxannostate = cboxannoparam.AsInteger()
curviewelements = DB.FilteredElementCollector(revit.doc)\
.OwnedByView(selview.Id)\
.WhereElementIsNotElementType()\
.ToElements()

viewspecificelements = []
for el in curviewelements:
if el.ViewSpecific \
and not el.IsHidden(selview) \
and el.CanBeHidden(selview) \
and el.Category is not None:
viewspecificelements.append(el.Id)

basepoints = DB.FilteredElementCollector(revit.doc)\
.OfClass(DB.BasePoint)\
.WhereElementIsNotElementType()\
.ToElements()

excludecategories = ['Survey Point',
'Project Base Point']
for el in basepoints:
if el.Category and el.Category.Name in excludecategories:
viewspecificelements.append(el.Id)

with revit.TransactionGroup('Activate & Read Cropbox Boundary'):
with revit.Transaction('Hiding all 2d elements'):
if viewspecificelements:
try:
selview.HideElements(List[DB.ElementId](viewspecificelements))
except Exception as e:
logger.debug(e)

with revit.Transaction('Activate & Read Cropbox Boundary'):
selview.CropBoxActive = True
selview.CropBoxVisible = False
cboxannoparam.Set(0)

# get view min max points in modelUCS.
modelucsx = []
modelucsy = []
crsm = selview.GetCropRegionShapeManager()

cllist = crsm.GetCropShape()
if len(cllist) == 1:
cl = cllist[0]
for l in cl:
modelucsx.append(l.GetEndPoint(0).X)
modelucsy.append(l.GetEndPoint(0).Y)
cropmin = DB.XYZ(min(modelucsx), min(modelucsy), 0.0)
cropmax = DB.XYZ(max(modelucsx), max(modelucsy), 0.0)

# get vp min max points in sheetUCS
ol = selvp.GetBoxOutline()
vptempmin = ol.MinimumPoint
vpmin = DB.XYZ(vptempmin.X + vpboundaryoffset,
vptempmin.Y + vpboundaryoffset, 0.0)
vptempmax = ol.MaximumPoint
vpmax = DB.XYZ(vptempmax.X - vpboundaryoffset,
vptempmax.Y - vpboundaryoffset, 0.0)

transmatrix.sourcemin = vpmin
transmatrix.sourcemax = vpmax
transmatrix.destmin = cropmin
transmatrix.destmax = cropmax

revtransmatrix.sourcemin = cropmin
revtransmatrix.sourcemax = cropmax
revtransmatrix.destmin = vpmin
revtransmatrix.destmax = vpmax

selview.CropBoxActive = cboxactive
selview.CropBoxVisible = cboxvisible
cboxannoparam.Set(cboxannostate)

if viewspecificelements:
selview.UnhideElements(
List[DB.ElementId](viewspecificelements)
)
transmatrix = vpu.TransformationMatrix()
revtransmatrix = vpu.TransformationMatrix()

datafile = \
script.get_document_data_file(file_id='SaveViewportLocation',
file_ext='pym',
add_cmd_name=False)

selected_ids = revit.get_selection().element_ids

if len(selected_ids) == 1:
vport_id = selected_ids[0]
try:
vport = revit.doc.GetElement(vport_id)
except Exception:
forms.alert('Select exactly one viewport.')

if isinstance(vport, DB.Viewport):
view = revit.doc.GetElement(vport.ViewId)
if view is not None and isinstance(view, DB.ViewPlan):
with revit.TransactionGroup('Copy Viewport Location'):
set_tansform_matrix(vport, view)
center = vport.GetBoxCenter()
modelpoint = sheet_to_view_transform(center)
center_pt = Point(center.X, center.Y, center.Z)
model_pt = Point(modelpoint.X, modelpoint.Y, modelpoint.Z)
with open(datafile, 'wb') as fp:
originalviewtype = 'ViewPlan'
pickle.dump(originalviewtype, fp)
pickle.dump(center_pt, fp)
pickle.dump(model_pt, fp)

elif view is not None and isinstance(view, DB.ViewDrafting):
center = vport.GetBoxCenter()
center_pt = Point(center.X, center.Y, center.Z)
with open(datafile, 'wb') as fp:
originalviewtype = 'ViewDrafting'
pickle.dump(originalviewtype, fp)
pickle.dump(center_pt, fp)
else:
forms.alert('This tool only works with Plan, '
'RCP, and Detail views and viewports.')
view = revit.doc.GetElement(vport.ViewId)
if view is not None and isinstance(view, DB.ViewPlan):
with revit.TransactionGroup('Copy Viewport Location'):
vpu.set_tansform_matrix(vport, view)
center = vport.GetBoxCenter()
modelpoint = vpu.sheet_to_view_transform(center)
center_pt = vpu.Point(center.X, center.Y, center.Z)
model_pt = vpu.Point(modelpoint.X, modelpoint.Y, modelpoint.Z)
with open(datafile, 'wb') as fp:
originalviewtype = 'ViewPlan'
pickle.dump(originalviewtype, fp)
pickle.dump(center_pt, fp)
pickle.dump(model_pt, fp)

elif view is not None and isinstance(view, DB.ViewDrafting):
center = vport.GetBoxCenter()
center_pt = vpu.Point(center.X, center.Y, center.Z)
with open(datafile, 'wb') as fp:
originalviewtype = 'ViewDrafting'
pickle.dump(originalviewtype, fp)
pickle.dump(center_pt, fp)
else:
forms.alert('Select exactly one viewport.')
forms.alert('This tool only works with Plan, '
'RCP, and Detail views and viewports.')

elif selected_option == 'Visibility Graphics':
datafile = \
Expand Down
Loading