Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all params availables from run #144

Merged
merged 5 commits into from
Jan 31, 2023
Merged

Make all params availables from run #144

merged 5 commits into from
Jan 31, 2023

Conversation

MateoLostanlen
Copy link
Member

@MateoLostanlen MateoLostanlen commented Jan 30, 2023 •
edited
Loading

The purpose of this pr is to make all engine parameters accessible from run so it is easier to test different configurations.

Also I changed some default values.

frame_size 4k > 720,1280 the 4k image is too heavy for some towers

jpeg_quality 50 > 80, the compression was too strong with some artifacts especially in low light

cache-size 100 > 20 to try not to saturate the ram

alert_relaxation 3 > 2 because the model is better now I propose to decrease the alert_relaxation

@MateoLostanlen MateoLostanlen requested review from a team January 30, 2023 20:44
@MateoLostanlen MateoLostanlen self-assigned this Jan 30, 2023
fe51
fe51 approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@fe51 fe51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to have all params available as args

frgfm
frgfm approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MateoLostanlen MateoLostanlen merged commit 07af20b into pyronear:develop Jan 31, 2023
MateoLostanlen added a commit that referenced this pull request Feb 2, 2023
@MateoLostanlen
Update of the main branch before the new deployment in Ardeche (#145)
4b5406e 
* ci on develop (#134)

* update develop tour (#135)

* fix args (#136)

* fix: Fixed script arg name in src/run.py (#138)

* clean backup by size (#141)

* clean backup by size

* black

* missing deps

* drop function

* drop function 2

* Day only (#142)

* sunset_sunrise script

* update output file path

* check if day time

* put back real api

* style

* use datetime timedelta

* Make all params availables from run (#144)

* make all params available in run

* make params availables

* put back api

* style

* put back alert_relaxation to 2

* Yolov5 (#143)

* switch to yolov5

* missing import

* style

* fix tests

* unused import

* update readme

* letterbox transform

* do not resize with pillow before pred

* style

* downgrad opencv

* wrong img name

* long line

* missing deps

* model path

* header

* lib for opencv

* create model folder

* update init

* remove hub deps

* update threshold
@MateoLostanlen MateoLostanlen deleted the make_all_params_availables branch April 16, 2023 13:31
fe51 added a commit that referenced this pull request Apr 19, 2023
@fe51 @MateoLostanlen
Promtail (#152)
6db116c 
* Update of the main branch before the new deployment in Ardeche (#145)

* ci on develop (#134)

* update develop tour (#135)

* fix args (#136)

* fix: Fixed script arg name in src/run.py (#138)

* clean backup by size (#141)

* clean backup by size

* black

* missing deps

* drop function

* drop function 2

* Day only (#142)

* sunset_sunrise script

* update output file path

* check if day time

* put back real api

* style

* use datetime timedelta

* Make all params availables from run (#144)

* make all params available in run

* make params availables

* put back api

* style

* put back alert_relaxation to 2

* Yolov5 (#143)

* switch to yolov5

* missing import

* style

* fix tests

* unused import

* update readme

* letterbox transform

* do not resize with pillow before pred

* style

* downgrad opencv

* wrong img name

* long line

* missing deps

* model path

* header

* lib for opencv

* create model folder

* update init

* remove hub deps

* update threshold

* feat: Added promtail service

* feat: Added promtail config file

* feat: Renamed variable

* feat: Renamed vars

* docs: Updated setup explanation

* feat: Added restart option

---------

Co-authored-by: Mateo <mateo.lostanlen@gmail.com>
MateoLostanlen added a commit that referenced this pull request Apr 21, 2023
@MateoLostanlen
Fix git tree (#157)
8317c5e 
* ci on develop (#134)

* update develop tour (#135)

* fix args (#136)

* fix: Fixed script arg name in src/run.py (#138)

* clean backup by size (#141)

* clean backup by size

* black

* missing deps

* drop function

* drop function 2

* Day only (#142)

* sunset_sunrise script

* update output file path

* check if day time

* put back real api

* style

* use datetime timedelta

* Make all params availables from run (#144)

* make all params available in run

* make params availables

* put back api

* style

* put back alert_relaxation to 2

* Yolov5 (#143)

* switch to yolov5

* missing import

* style

* fix tests

* unused import

* update readme

* letterbox transform

* do not resize with pillow before pred

* style

* downgrad opencv

* wrong img name

* long line

* missing deps

* model path

* header

* lib for opencv

* create model folder

* update init

* remove hub deps

* update threshold
MateoLostanlen added a commit that referenced this pull request Apr 21, 2023
@MateoLostanlen @fe51
Update of the main branch (#156)
d0ab8bd 
* update header (#149)

* fix black (#150)

* Update README.md (#151)

* Promtail (#152)

* Update of the main branch before the new deployment in Ardeche (#145)

* ci on develop (#134)

* update develop tour (#135)

* fix args (#136)

* fix: Fixed script arg name in src/run.py (#138)

* clean backup by size (#141)

* clean backup by size

* black

* missing deps

* drop function

* drop function 2

* Day only (#142)

* sunset_sunrise script

* update output file path

* check if day time

* put back real api

* style

* use datetime timedelta

* Make all params availables from run (#144)

* make all params available in run

* make params availables

* put back api

* style

* put back alert_relaxation to 2

* Yolov5 (#143)

* switch to yolov5

* missing import

* style

* fix tests

* unused import

* update readme

* letterbox transform

* do not resize with pillow before pred

* style

* downgrad opencv

* wrong img name

* long line

* missing deps

* model path

* header

* lib for opencv

* create model folder

* update init

* remove hub deps

* update threshold

* feat: Added promtail service

* feat: Added promtail config file

* feat: Renamed variable

* feat: Renamed vars

* docs: Updated setup explanation

* feat: Added restart option

---------

Co-authored-by: Mateo <mateo.lostanlen@gmail.com>

* analyze stream timeout (#153)

* update docker img (#154)

* add utc (#155)

* fix style (#158)

---------

Co-authored-by: fe51 <55736935+fe51@users.noreply.github.com>
MateoLostanlen added a commit that referenced this pull request Jun 1, 2023
@MateoLostanlen @fe51
Merge develop (#160)
d1afeca 
* update header (#149)

* fix black (#150)

* Update README.md (#151)

* Promtail (#152)

* Update of the main branch before the new deployment in Ardeche (#145)

* ci on develop (#134)

* update develop tour (#135)

* fix args (#136)

* fix: Fixed script arg name in src/run.py (#138)

* clean backup by size (#141)

* clean backup by size

* black

* missing deps

* drop function

* drop function 2

* Day only (#142)

* sunset_sunrise script

* update output file path

* check if day time

* put back real api

* style

* use datetime timedelta

* Make all params availables from run (#144)

* make all params available in run

* make params availables

* put back api

* style

* put back alert_relaxation to 2

* Yolov5 (#143)

* switch to yolov5

* missing import

* style

* fix tests

* unused import

* update readme

* letterbox transform

* do not resize with pillow before pred

* style

* downgrad opencv

* wrong img name

* long line

* missing deps

* model path

* header

* lib for opencv

* create model folder

* update init

* remove hub deps

* update threshold

* feat: Added promtail service

* feat: Added promtail config file

* feat: Renamed variable

* feat: Renamed vars

* docs: Updated setup explanation

* feat: Added restart option

---------

Co-authored-by: Mateo <mateo.lostanlen@gmail.com>

* analyze stream timeout (#153)

* update docker img (#154)

* add utc (#155)

* fix style (#158)

* Ir day night (#159)

* set margin to 0

* drop utc

* add ir strategy

* update docstring

* fix style

* fix missing undefinded params (#161)

---------

Co-authored-by: fe51 <55736935+fe51@users.noreply.github.com>
MateoLostanlen added a commit that referenced this pull request Aug 16, 2023
@MateoLostanlen @fe51
Merge to main (#172)
0782fee 
* update header (#149)

* fix black (#150)

* Update README.md (#151)

* Promtail (#152)

* Update of the main branch before the new deployment in Ardeche (#145)

* ci on develop (#134)

* update develop tour (#135)

* fix args (#136)

* fix: Fixed script arg name in src/run.py (#138)

* clean backup by size (#141)

* clean backup by size

* black

* missing deps

* drop function

* drop function 2

* Day only (#142)

* sunset_sunrise script

* update output file path

* check if day time

* put back real api

* style

* use datetime timedelta

* Make all params availables from run (#144)

* make all params available in run

* make params availables

* put back api

* style

* put back alert_relaxation to 2

* Yolov5 (#143)

* switch to yolov5

* missing import

* style

* fix tests

* unused import

* update readme

* letterbox transform

* do not resize with pillow before pred

* style

* downgrad opencv

* wrong img name

* long line

* missing deps

* model path

* header

* lib for opencv

* create model folder

* update init

* remove hub deps

* update threshold

* feat: Added promtail service

* feat: Added promtail config file

* feat: Renamed variable

* feat: Renamed vars

* docs: Updated setup explanation

* feat: Added restart option

---------

Co-authored-by: Mateo <mateo.lostanlen@gmail.com>

* analyze stream timeout (#153)

* update docker img (#154)

* add utc (#155)

* fix style (#158)

* Ir day night (#159)

* set margin to 0

* drop utc

* add ir strategy

* update docstring

* fix style

* fix missing undefinded params (#161)

* Add bbox (#162)

* add bbox

* fix inference

* style

* fix vision

* style vision

* fix engine

* keep all preds

* speed up

* pass dummy loc

* switch to v8

* fix tests

* test

* drop dummy test

* new api version

* unsed import

* install git

* code quality

* use bbox branch

* use apt get

* alert relaxation 3

* New alerte strategy (#164)

* new alert system

* fix unitests

* Occlusion mask (#165)

* add occlusion mask

* trest mask

* missing args

* use cam_key

* update test

* add a test

* clip values

* install from main (#167)

* limit bbox size (#166)

* limit bbox size

* style

* use 4 frames (#168)

* don't send bbox (#169)

* prevent empty (#171)

---------

Co-authored-by: fe51 <55736935+fe51@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fe51 fe51 fe51 approved these changes

@frgfm frgfm frgfm approved these changes

Assignees

@MateoLostanlen MateoLostanlen

Labels
ext: src
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MateoLostanlen @frgfm @fe51