Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix style #158

Merged
merged 1 commit into from
Apr 21, 2023
Merged

fix style #158

merged 1 commit into from
Apr 21, 2023

Conversation

MateoLostanlen
Copy link
Member

We have a few tests that fail, I will take time to fix this soon. I didn’t notice with my previous PR that the style was not good. Small PR to fix this

@MateoLostanlen MateoLostanlen added the invalid This doesn't seem right label Apr 21, 2023
@MateoLostanlen MateoLostanlen requested a review from a team April 21, 2023 09:07
@MateoLostanlen MateoLostanlen self-assigned this Apr 21, 2023
@MateoLostanlen MateoLostanlen merged commit ffee3dc into pyronear:develop Apr 21, 2023
MateoLostanlen added a commit that referenced this pull request Apr 21, 2023
* update header (#149)

* fix black (#150)

* Update README.md (#151)

* Promtail (#152)

* Update of the main branch before the new deployment in Ardeche (#145)

* ci on develop (#134)

* update develop tour (#135)

* fix args (#136)

* fix: Fixed script arg name in src/run.py (#138)

* clean backup by size (#141)

* clean backup by size

* black

* missing deps

* drop function

* drop function 2

* Day only (#142)

* sunset_sunrise script

* update output file path

* check if day time

* put back real api

* style

* use datetime timedelta

* Make all params availables from run (#144)

* make all params available in run

* make params availables

* put back api

* style

* put back alert_relaxation to 2

* Yolov5 (#143)

* switch to yolov5

* missing import

* style

* fix tests

* unused import

* update readme

* letterbox transform

* do not resize with pillow before pred

* style

* downgrad opencv

* wrong img name

* long line

* missing deps

* model path

* header

* lib for opencv

* create model folder

* update init

* remove hub deps

* update threshold

* feat: Added promtail service

* feat: Added promtail config file

* feat: Renamed variable

* feat: Renamed vars

* docs: Updated setup explanation

* feat: Added restart option

---------

Co-authored-by: Mateo <mateo.lostanlen@gmail.com>

* analyze stream timeout (#153)

* update docker img (#154)

* add utc (#155)

* fix style (#158)

---------

Co-authored-by: fe51 <55736935+fe51@users.noreply.github.com>
@MateoLostanlen MateoLostanlen deleted the fix_style branch April 21, 2023 09:52
MateoLostanlen added a commit that referenced this pull request Jun 1, 2023
* update header (#149)

* fix black (#150)

* Update README.md (#151)

* Promtail (#152)

* Update of the main branch before the new deployment in Ardeche (#145)

* ci on develop (#134)

* update develop tour (#135)

* fix args (#136)

* fix: Fixed script arg name in src/run.py (#138)

* clean backup by size (#141)

* clean backup by size

* black

* missing deps

* drop function

* drop function 2

* Day only (#142)

* sunset_sunrise script

* update output file path

* check if day time

* put back real api

* style

* use datetime timedelta

* Make all params availables from run (#144)

* make all params available in run

* make params availables

* put back api

* style

* put back alert_relaxation to 2

* Yolov5 (#143)

* switch to yolov5

* missing import

* style

* fix tests

* unused import

* update readme

* letterbox transform

* do not resize with pillow before pred

* style

* downgrad opencv

* wrong img name

* long line

* missing deps

* model path

* header

* lib for opencv

* create model folder

* update init

* remove hub deps

* update threshold

* feat: Added promtail service

* feat: Added promtail config file

* feat: Renamed variable

* feat: Renamed vars

* docs: Updated setup explanation

* feat: Added restart option

---------

Co-authored-by: Mateo <mateo.lostanlen@gmail.com>

* analyze stream timeout (#153)

* update docker img (#154)

* add utc (#155)

* fix style (#158)

* Ir day night (#159)

* set margin to 0

* drop utc

* add ir strategy

* update docstring

* fix style

* fix missing undefinded params (#161)

---------

Co-authored-by: fe51 <55736935+fe51@users.noreply.github.com>
MateoLostanlen added a commit that referenced this pull request Aug 16, 2023
* update header (#149)

* fix black (#150)

* Update README.md (#151)

* Promtail (#152)

* Update of the main branch before the new deployment in Ardeche (#145)

* ci on develop (#134)

* update develop tour (#135)

* fix args (#136)

* fix: Fixed script arg name in src/run.py (#138)

* clean backup by size (#141)

* clean backup by size

* black

* missing deps

* drop function

* drop function 2

* Day only (#142)

* sunset_sunrise script

* update output file path

* check if day time

* put back real api

* style

* use datetime timedelta

* Make all params availables from run (#144)

* make all params available in run

* make params availables

* put back api

* style

* put back alert_relaxation to 2

* Yolov5 (#143)

* switch to yolov5

* missing import

* style

* fix tests

* unused import

* update readme

* letterbox transform

* do not resize with pillow before pred

* style

* downgrad opencv

* wrong img name

* long line

* missing deps

* model path

* header

* lib for opencv

* create model folder

* update init

* remove hub deps

* update threshold

* feat: Added promtail service

* feat: Added promtail config file

* feat: Renamed variable

* feat: Renamed vars

* docs: Updated setup explanation

* feat: Added restart option

---------

Co-authored-by: Mateo <mateo.lostanlen@gmail.com>

* analyze stream timeout (#153)

* update docker img (#154)

* add utc (#155)

* fix style (#158)

* Ir day night (#159)

* set margin to 0

* drop utc

* add ir strategy

* update docstring

* fix style

* fix missing undefinded params (#161)

* Add bbox (#162)

* add bbox

* fix inference

* style

* fix vision

* style vision

* fix engine

* keep all preds

* speed up

* pass dummy loc

* switch to v8

* fix tests

* test

* drop dummy test

* new api version

* unsed import

* install git

* code quality

* use bbox branch

* use apt get

* alert relaxation 3

* New alerte strategy (#164)

* new alert system

* fix unitests

* Occlusion mask (#165)

* add occlusion mask

* trest mask

* missing args

* use cam_key

* update test

* add a test

* clip values

* install from main (#167)

* limit bbox size (#166)

* limit bbox size

* style

* use 4 frames (#168)

* don't send bbox (#169)

* prevent empty (#171)

---------

Co-authored-by: fe51 <55736935+fe51@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant