Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update licence #70

Merged
merged 17 commits into from
Feb 18, 2022
Merged

Update licence #70

merged 17 commits into from
Feb 18, 2022

Conversation

fe51
Copy link
Member

@fe51 fe51 commented Feb 14, 2022

Hi there, a PR to update the licence to apache 2.0, inspired by pyronear/pyro-vision#132

It introduces the following changes :

  • updates licence to Apache 2.0
  • updates headers
  • adds script to check headers (copied from pyro-vision authored by frgfm)
  • add ci job to check headers (copied from pyro-vision)

Happy to discuss it : especially, I am not knowledgeable in CI jobs so I do not know if its works.

@fe51 fe51 requested review from MateoLostanlen and frgfm February 14, 2022 12:19
@fe51 fe51 added topic: documentation Improvements or additions to documentation topic: build Related to build, installation & CI labels Feb 14, 2022
@fe51 fe51 requested review from Akilditu and blenzi February 14, 2022 12:22
@fe51 fe51 self-assigned this Feb 14, 2022
Copy link
Member

@MateoLostanlen MateoLostanlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to bring it here too :)

Copy link
Member

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! There is only a small mistake on the copyright year :)

.github/validate_headers.py Outdated Show resolved Hide resolved
docs/source/conf.py Outdated Show resolved Hide resolved
@fe51
Copy link
Member Author

fe51 commented Feb 14, 2022

copyright year corrected :)

@fe51 fe51 requested review from frgfm and MateoLostanlen February 14, 2022 17:28
Copy link
Member

@MateoLostanlen MateoLostanlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix !

@fe51
Copy link
Member Author

fe51 commented Feb 16, 2022

@frgfm I think we are good now !

Copy link
Member

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

@fe51 fe51 merged commit 0d461ce into develop Feb 18, 2022
@fe51 fe51 deleted the update-licence branch February 18, 2022 10:04
MateoLostanlen added a commit that referenced this pull request Jul 2, 2022
* ci on develop (#68)

No code update here, only configuration. I take the liberty to use admin privileges to merge

* Code of conduct (#71)

* docs: Added code of conduct md file

* docs: Updated CONTRIBUTING file, related to code of conduct

* Update licence (#70)

* nothing

* nothing

* docs: Updated licence to Apache 2.0

* docs: Updated README

* docs: Updated setup.py

* chore : added script to check headers

script copied from pyro-vision and authored by frgfm

* chore : updated folders to check

* docs : updated all headers

* chore: add ci job to check headers

* style : added line at end of file to fix linter

* docs: corrected repo starting year in headers & setup

* fix version (#73)

* pyrovision from repo (#72)

* Fix docker (#66)

* use pyronear docker hub

* issue with pyro-vision version

* simplify web server docker

* fix versions for production

* remove space

* add update script (#67)

* add update script

* add crontab exemple

* add monitor runner (#74)

* change default loop interval (#75)

Co-authored-by: fe51 <55736935+fe51@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: build Related to build, installation & CI topic: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants