Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default loop interval #75

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

MateoLostanlen
Copy link
Member

The default time between two frames should be 30s and not 3

@MateoLostanlen MateoLostanlen added the invalid This doesn't seem right label Mar 18, 2022
@MateoLostanlen MateoLostanlen requested review from frgfm, fe51 and a team March 18, 2022 21:39
@MateoLostanlen MateoLostanlen self-assigned this Mar 18, 2022
@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #75 (be163e9) into develop (07d05b0) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop      #75   +/-   ##
========================================
  Coverage    68.69%   68.69%           
========================================
  Files            7        7           
  Lines          230      230           
========================================
  Hits           158      158           
  Misses          72       72           
Flag Coverage Δ
unittests 68.69% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyroengine/pi_utils/pi_zeros/runner.py 80.76% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7faa0ce...be163e9. Read the comment docs.

Copy link
Member

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do you mean we were taking pictures every 3 seconds until now?

Copy link
Member

@fe51 fe51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update !

@MateoLostanlen
Copy link
Member Author

Thanks! Do you mean we were taking pictures every 3 seconds until now?

No I've made the change by hand :) And I forget to right this PR

@MateoLostanlen MateoLostanlen merged commit 87bbcc4 into pyronear:develop Mar 21, 2022
MateoLostanlen added a commit that referenced this pull request Jul 2, 2022
* ci on develop (#68)

No code update here, only configuration. I take the liberty to use admin privileges to merge

* Code of conduct (#71)

* docs: Added code of conduct md file

* docs: Updated CONTRIBUTING file, related to code of conduct

* Update licence (#70)

* nothing

* nothing

* docs: Updated licence to Apache 2.0

* docs: Updated README

* docs: Updated setup.py

* chore : added script to check headers

script copied from pyro-vision and authored by frgfm

* chore : updated folders to check

* docs : updated all headers

* chore: add ci job to check headers

* style : added line at end of file to fix linter

* docs: corrected repo starting year in headers & setup

* fix version (#73)

* pyrovision from repo (#72)

* Fix docker (#66)

* use pyronear docker hub

* issue with pyro-vision version

* simplify web server docker

* fix versions for production

* remove space

* add update script (#67)

* add update script

* add crontab exemple

* add monitor runner (#74)

* change default loop interval (#75)

Co-authored-by: fe51 <55736935+fe51@users.noreply.github.com>
@MateoLostanlen MateoLostanlen deleted the default_delay branch July 24, 2022 17:21
@frgfm frgfm added type: enhancement New feature or request ext: src and removed invalid This doesn't seem right labels Aug 7, 2022
@frgfm frgfm added this to the 0.2.0 milestone Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: src type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants