LSCP-B

[erinrolson]

Implements LSCPB class for GSoC '22

[codecov]

Codecov Report

Merging #259 (6888fcc) into main (57b3abc) will increase coverage by 1.1%.
The diff coverage is 96.2%.

@@           Coverage Diff           @@
##            main    #259     +/-   ##
=======================================
+ Coverage   66.1%   67.2%   +1.1%     
=======================================
  Files         23      23             
  Lines       2582    2659     +77     
  Branches     566     583     +17     
=======================================
+ Hits        1706    1787     +81     
+ Misses       790     781      -9     
- Partials      86      91      +5     

Impacted Files	Coverage Δ
spopt/locate/base.py	94.4% <84.6%> (+0.5%)	⬆️
spopt/locate/coverage.py	99.0% <98.5%> (-0.2%)	⬇️
spopt/_version.py	33.8% <0.0%> (+1.5%)	⬆️

[jGaboardi]

Phenomenal work, @erinrolson! This is a great start here! I think next we need to think about:

• adding in tests for the LSCP-B; and
• creating a notebook demonstrating the LSCP-B

[jGaboardi]

cc @qszhao

[jGaboardi]

@erinrolson Let's remove the .coverage file from this PR. This file should actually be on the .gitignore list, but we seem to have left it out.

[jGaboardi]

@erinrolson I think after removing the .coverage file from this PR it will be ready for approval.

[gegen07]

• Could you run the lscpb notebook from the beginning? It starts from 30th cell.
• Maybe we can add the plot_results function to util file? We are using it in all notebooks. @jGaboardi what do you think?

@erinrolson just small changes to wrap up this awesome work!

[jGaboardi]

Maybe we can add the plot_results function to util file? We are using it in all notebooks. @jGaboardi what do you think?

@gegen07 This could be a nice idea (though not for this PR). We may also discuss integrating viz functionality with splot.

[gegen07]

Thanks @erinrolson for your awesome contribution!! 🎉