feat: m3u8 parsing for quality selection,auto-update base-url, optimizations #638
Conversation
feat:m3u8 parsing, auto-update base-url, optimizations
ani-cli
Outdated
| @@ -98,8 +97,8 @@ download () { | |||
| case $2 in | |||
| *mp4*) | |||
| aria2c --summary-interval=0 -x 16 -s 16 --referer="$1" "$2" --dir="$download_dir" -o "${3}-${4}.mp4" --download-result=hide ;; | |||
| *) | |||
| ffmpeg -loglevel error -stats -referer "$1" -i "$2" -c copy "$download_dir/${3}-${4}.mp4" ;; | |||
| *) | |||
|
Readme should also be updated according to the last stable version... |
|
Also as a general rule of thumb for maintainers, prefer doing development on pystardust/ani-cli on a seperate branch, rather than developing on a fork. |
Oky.. will take care of it.. |
Ok noted👍 |
| get_video_quality_m3u8() { | ||
| case $quality in | ||
| worst|360) | ||
| idx=2 ;; | ||
| 480) | ||
| idx=3 ;; | ||
| 720) | ||
| idx=4 ;; | ||
| 1080|best) | ||
| idx=5 ;; | ||
| *) |
There was a problem hiding this comment.
I know there was an earlier commit by @CoolnsX that aimed to deduplicate, but it still seems like this is redundant, am I missing sth?
There was a problem hiding this comment.
Oh, this is just because we have people put in worst, 360, 480, 720, 1080, best as the optarg to -q.
Doesn't seem like there is an easy way to deduplicate it further, but maybe someone has an idea?
There was a problem hiding this comment.
Seems unlikely
|
I also only read through the code this time |
|
good call to bump to 2.1.0 |
#630