Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: m3u8 parsing for quality selection,auto-update base-url, optimizations #638
feat: m3u8 parsing for quality selection,auto-update base-url, optimizations #638
Changes from all commits
f269968
f923928
0c2bc5f
6f25c0e
5db3d75
7ce45e1
a6f1a99
579983d
1449884
44246a2
62bf320
f7ff4e4
75b5f15
b8cc4d5
b62ce36
244a355
6aebb2b
f30df15
07712f2
509cff7
827e524
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know there was an earlier commit by @CoolnsX that aimed to deduplicate, but it still seems like this is redundant, am I missing sth?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this is just because we have people put in
worst, 360, 480, 720, 1080, best
as the optarg to-q
.Doesn't seem like there is an easy way to deduplicate it further, but maybe someone has an idea?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems unlikely