Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show trace on keyboardinterrupt #1366

Closed
hpk42 opened this issue Feb 8, 2016 · 2 comments
Closed

show trace on keyboardinterrupt #1366

hpk42 opened this issue Feb 8, 2016 · 2 comments
Assignees
@RonnyPfannschmidt
Labels
good first issue easy issue that is friendly to new contributor status: help wanted developers would like help from experts on this topic type: enhancement new feature or API change, should be merged into features branch type: feature-branch new feature or API change, should be merged into features branch
Milestone
2.9

Comments

@hpk42
Copy link
Contributor

hpk42 commented Feb 8, 2016

When CTRL-C/keyboard-interrupt a hanging test pytest does not show a stacktrace. You can enable it via "--fulltrace" but that's not obvious. So we should add a hint when ctrl-c happens.

we could also show the traceback by default but sometimes one hits ctrl-c because one realizes the invocation was wrong or something and then showing long tracebacks by default is obnoxious. So i suggest we stick with how things are and add something to the message
@RonnyPfannschmidt
Copy link
Member

👍 we had a similar request before and already decided we shouldnt always show the trace

@RonnyPfannschmidt RonnyPfannschmidt added this to the 2.9 milestone Feb 8, 2016
@RonnyPfannschmidt RonnyPfannschmidt added type: enhancement new feature or API change, should be merged into features branch status: help wanted developers would like help from experts on this topic good first issue easy issue that is friendly to new contributor type: feature-branch new feature or API change, should be merged into features branch labels Feb 8, 2016
@RonnyPfannschmidt RonnyPfannschmidt self-assigned this Feb 10, 2016
RonnyPfannschmidt added a commit to RonnyPfannschmidt/pytest that referenced this issue Feb 10, 2016
@RonnyPfannschmidt
fix issue pytest-dev#1366 by showing a note on the --fulltrace option
1606a06
RonnyPfannschmidt added a commit to RonnyPfannschmidt/pytest that referenced this issue Feb 10, 2016
@RonnyPfannschmidt
fix issue pytest-dev#1366 by showing a note on the --fulltrace option
9eac192
RonnyPfannschmidt added a commit to RonnyPfannschmidt/pytest that referenced this issue Feb 10, 2016
@RonnyPfannschmidt
fix issue pytest-dev#1366 by showing a note on the --fulltrace option
f0b221c
RonnyPfannschmidt added a commit to RonnyPfannschmidt/pytest that referenced this issue Feb 10, 2016
@RonnyPfannschmidt
fix issue pytest-dev#1366 by showing a note on the --fulltrace option
bfa2fad
hpk42 added a commit that referenced this issue Feb 11, 2016
@hpk42
Merge pull request #1374 from RonnyPfannschmidt/fix-1366
b1955c7 
fix issue #1366 by showing a note on the --fulltrace option
@omarkohl omarkohl mentioned this issue Feb 23, 2016
Closed
@The-Compiler
Copy link
Member

Closing as #1374 was merged (@RonnyPfannschmidt, if you say "fix #1366" instead of "fix issue #1366", GitHub will autoclose the issues)

jsonn pushed a commit to jsonn/pkgsrc that referenced this issue Apr 14, 2016
Update py-test to 2.9.1.
416bbff 
2.9.1
=====

**Bug Fixes**

* Improve error message when a plugin fails to load.
  Thanks `@nicoddemus`_ for the PR.

* Fix (`#1178 <https://github.com/pytest-dev/pytest/issues/1178>`_):
  ``pytest.fail`` with non-ascii characters raises an internal pytest error.
  Thanks `@nicoddemus`_ for the PR.

* Fix (`#469`_): junit parses report.nodeid incorrectly, when params IDs
  contain ``::``. Thanks `@tomviner`_ for the PR (`#1431`_).

* Fix (`#578 <https://github.com/pytest-dev/pytest/issues/578>`_): SyntaxErrors
  containing non-ascii lines at the point of failure generated an internal
  py.test error.
  Thanks `@asottile`_ for the report and `@nicoddemus`_ for the PR.

* Fix (`#1437`_): When passing in a bytestring regex pattern to parameterize
  attempt to decode it as utf-8 ignoring errors.

* Fix (`#649`_): parametrized test nodes cannot be specified to run on the command line.


.. _#1437: pytest-dev/pytest#1437
.. _#469: pytest-dev/pytest#469
.. _#1431: pytest-dev/pytest#1431
.. _#649: pytest-dev/pytest#649

.. _@asottile: https://github.com/asottile


2.9.0
=====

**New Features**

* New ``pytest.mark.skip`` mark, which unconditionally skips marked tests.
  Thanks `@MichaelAquilina`_ for the complete PR (`#1040`_).

* ``--doctest-glob`` may now be passed multiple times in the command-line.
  Thanks `@jab`_ and `@nicoddemus`_ for the PR.

* New ``-rp`` and ``-rP`` reporting options give the summary and full output
  of passing tests, respectively. Thanks to `@codewarrior0`_ for the PR.

* ``pytest.mark.xfail`` now has a ``strict`` option, which makes ``XPASS``
  tests to fail the test suite (defaulting to ``False``). There's also a
  ``xfail_strict`` ini option that can be used to configure it project-wise.
  Thanks `@rabbbit`_ for the request and `@nicoddemus`_ for the PR (`#1355`_).

* ``Parser.addini`` now supports options of type ``bool``.
  Thanks `@nicoddemus`_ for the PR.

* New ``ALLOW_BYTES`` doctest option. This strips ``b`` prefixes from byte strings
  in doctest output (similar to ``ALLOW_UNICODE``).
  Thanks `@jaraco`_ for the request and `@nicoddemus`_ for the PR (`#1287`_).

* Give a hint on ``KeyboardInterrupt`` to use the ``--fulltrace`` option to show the errors.
  Fixes `#1366`_.
  Thanks to `@hpk42`_ for the report and `@RonnyPfannschmidt`_ for the PR.

* Catch ``IndexError`` exceptions when getting exception source location.
  Fixes a pytest internal error for dynamically generated code (fixtures and tests)
  where source lines are fake by intention.

**Changes**

* **Important**: `py.code <http://pylib.readthedocs.org/en/latest/code.html>`_ has been
  merged into the ``pytest`` repository as ``pytest._code``. This decision
  was made because ``py.code`` had very few uses outside ``pytest`` and the
  fact that it was in a different repository made it difficult to fix bugs on
  its code in a timely manner. The team hopes with this to be able to better
  refactor out and improve that code.
  This change shouldn't affect users, but it is useful to let users aware
  if they encounter any strange behavior.

  Keep in mind that the code for ``pytest._code`` is **private** and
  **experimental**, so you definitely should not import it explicitly!

  Please note that the original ``py.code`` is still available in
  `pylib <http://pylib.readthedocs.org>`_.

* ``pytest_enter_pdb`` now optionally receives the pytest config object.
  Thanks `@nicoddemus`_ for the PR.

* Removed code and documentation for Python 2.5 or lower versions,
  including removal of the obsolete ``_pytest.assertion.oldinterpret`` module.
  Thanks `@nicoddemus`_ for the PR (`#1226`_).

* Comparisons now always show up in full when ``CI`` or ``BUILD_NUMBER`` is
  found in the environment, even when ``-vv`` isn't used.
  Thanks `@The-Compiler`_ for the PR.

* ``--lf`` and ``--ff`` now support long names: ``--last-failed`` and
  ``--failed-first`` respectively.
  Thanks `@MichaelAquilina`_ for the PR.

* Added expected exceptions to ``pytest.raises`` fail message.

* Collection only displays progress ("collecting X items") when in a terminal.
  This avoids cluttering the output when using ``--color=yes`` to obtain
  colors in CI integrations systems (`#1397`_).

**Bug Fixes**

* The ``-s`` and ``-c`` options should now work under ``xdist``;
  ``Config.fromdictargs`` now represents its input much more faithfully.
  Thanks to `@bukzor`_ for the complete PR (`#680`_).

* Fix (`#1290`_): support Python 3.5's ``@`` operator in assertion rewriting.
  Thanks `@Shinkenjoe`_ for report with test case and `@tomviner`_ for the PR.

* Fix formatting utf-8 explanation messages (`#1379`_).
  Thanks `@biern`_ for the PR.

* Fix `traceback style docs`_ to describe all of the available options
  (auto/long/short/line/native/no), with `auto` being the default since v2.6.
  Thanks `@hackebrot`_ for the PR.

* Fix (`#1422`_): junit record_xml_property doesn't allow multiple records
  with same name.

.. _`traceback style docs`: https://pytest.org/latest/usage.html#modifying-python-traceback-printing

.. _#1422: pytest-dev/pytest#1422
.. _#1379: pytest-dev/pytest#1379
.. _#1366: pytest-dev/pytest#1366
.. _#1040: pytest-dev/pytest#1040
.. _#680: pytest-dev/pytest#680
.. _#1287: pytest-dev/pytest#1287
.. _#1226: pytest-dev/pytest#1226
.. _#1290: pytest-dev/pytest#1290
.. _#1355: pytest-dev/pytest#1355
.. _#1397: pytest-dev/pytest#1397
.. _@biern: https://github.com/biern
.. _@MichaelAquilina: https://github.com/MichaelAquilina
.. _@bukzor: https://github.com/bukzor
.. _@hpk42: https://github.com/hpk42
.. _@nicoddemus: https://github.com/nicoddemus
.. _@jab: https://github.com/jab
.. _@codewarrior0: https://github.com/codewarrior0
.. _@jaraco: https://github.com/jaraco
.. _@The-Compiler: https://github.com/The-Compiler
.. _@Shinkenjoe: https://github.com/Shinkenjoe
.. _@tomviner: https://github.com/tomviner
.. _@RonnyPfannschmidt: https://github.com/RonnyPfannschmidt
.. _@rabbbit: https://github.com/rabbbit
.. _@hackebrot: https://github.com/hackebrot
@pyup-bot pyup-bot mentioned this issue Jun 9, 2016
Merged
@pyup-bot pyup-bot mentioned this issue Jul 19, 2016
Merged
This was referenced Jul 26, 2016
Closed
Closed
@pyup-bot pyup-bot mentioned this issue Aug 13, 2016
Closed
This was referenced Aug 23, 2016
Closed
Closed
This was referenced Sep 23, 2016
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@pyup-bot pyup-bot mentioned this issue Jun 9, 2017
Closed
This was referenced Jul 11, 2017
Closed
Merged
Closed
This was referenced Jul 20, 2017
Merged
Merged
This was referenced Jul 28, 2017
Closed
Merged
Merged
This was referenced Aug 10, 2017
Closed
Closed
Merged
This was referenced Sep 1, 2017
Closed
Closed
Closed
This was referenced Sep 15, 2017
Merged
Merged
Merged
This was referenced Sep 29, 2017
Merged
Closed
Merged
Closed
@pyup-bot pyup-bot mentioned this issue Oct 16, 2017
Merged
This was referenced Oct 29, 2017
Closed
Open
Open
Closed
@dependencies dependencies bot mentioned this issue Nov 4, 2017
Merged
This was referenced Nov 11, 2017
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RonnyPfannschmidt RonnyPfannschmidt

Labels
good first issue easy issue that is friendly to new contributor status: help wanted developers would like help from experts on this topic type: enhancement new feature or API change, should be merged into features branch type: feature-branch new feature or API change, should be merged into features branch
Projects
None yet
Milestone
2.9
Development

No branches or pull requests
3 participants
@hpk42 @RonnyPfannschmidt @The-Compiler