issue469: add fix junit double colon split issue #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomviner
force-pushed
the
issue469-junit-double-colon
branch
from
356ec5a
to
2853083
Compare
| @@ -619,6 +620,20 @@ def test_func(char): | |||
| node.assert_attr(name="test_func[#x00]") | |||
|
|
|||
|
|
|||
| def test_double_colon_split_issue469(testdir): | |||
There was a problem hiding this comment.
Could you please also add another integration test, this time using a test method instead of a test function? Just to be safe. 😁
There was a problem hiding this comment.
Yeah I originally wrote one, but changed by mind!
Added in #1432
|
Thanks a lot for tackling this @tomviner! We really appreciate it. I would like for @RonnyPfannschmidt to take a second look if possible. Other than my comments, this looks good to me. 👍 |
|
looks fine, good work |
RonnyPfannschmidt
added a commit
that referenced
this pull request
Mar 3, 2016
fix #469 - correctly mangle junit test names when double colons are in parameter id's
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Apr 14, 2016
2.9.1 ===== **Bug Fixes** * Improve error message when a plugin fails to load. Thanks `@nicoddemus`_ for the PR. * Fix (`#1178 <https://github.com/pytest-dev/pytest/issues/1178>`_): ``pytest.fail`` with non-ascii characters raises an internal pytest error. Thanks `@nicoddemus`_ for the PR. * Fix (`#469`_): junit parses report.nodeid incorrectly, when params IDs contain ``::``. Thanks `@tomviner`_ for the PR (`#1431`_). * Fix (`#578 <https://github.com/pytest-dev/pytest/issues/578>`_): SyntaxErrors containing non-ascii lines at the point of failure generated an internal py.test error. Thanks `@asottile`_ for the report and `@nicoddemus`_ for the PR. * Fix (`#1437`_): When passing in a bytestring regex pattern to parameterize attempt to decode it as utf-8 ignoring errors. * Fix (`#649`_): parametrized test nodes cannot be specified to run on the command line. .. _#1437: pytest-dev/pytest#1437 .. _#469: pytest-dev/pytest#469 .. _#1431: pytest-dev/pytest#1431 .. _#649: pytest-dev/pytest#649 .. _@asottile: https://github.com/asottile 2.9.0 ===== **New Features** * New ``pytest.mark.skip`` mark, which unconditionally skips marked tests. Thanks `@MichaelAquilina`_ for the complete PR (`#1040`_). * ``--doctest-glob`` may now be passed multiple times in the command-line. Thanks `@jab`_ and `@nicoddemus`_ for the PR. * New ``-rp`` and ``-rP`` reporting options give the summary and full output of passing tests, respectively. Thanks to `@codewarrior0`_ for the PR. * ``pytest.mark.xfail`` now has a ``strict`` option, which makes ``XPASS`` tests to fail the test suite (defaulting to ``False``). There's also a ``xfail_strict`` ini option that can be used to configure it project-wise. Thanks `@rabbbit`_ for the request and `@nicoddemus`_ for the PR (`#1355`_). * ``Parser.addini`` now supports options of type ``bool``. Thanks `@nicoddemus`_ for the PR. * New ``ALLOW_BYTES`` doctest option. This strips ``b`` prefixes from byte strings in doctest output (similar to ``ALLOW_UNICODE``). Thanks `@jaraco`_ for the request and `@nicoddemus`_ for the PR (`#1287`_). * Give a hint on ``KeyboardInterrupt`` to use the ``--fulltrace`` option to show the errors. Fixes `#1366`_. Thanks to `@hpk42`_ for the report and `@RonnyPfannschmidt`_ for the PR. * Catch ``IndexError`` exceptions when getting exception source location. Fixes a pytest internal error for dynamically generated code (fixtures and tests) where source lines are fake by intention. **Changes** * **Important**: `py.code <http://pylib.readthedocs.org/en/latest/code.html>`_ has been merged into the ``pytest`` repository as ``pytest._code``. This decision was made because ``py.code`` had very few uses outside ``pytest`` and the fact that it was in a different repository made it difficult to fix bugs on its code in a timely manner. The team hopes with this to be able to better refactor out and improve that code. This change shouldn't affect users, but it is useful to let users aware if they encounter any strange behavior. Keep in mind that the code for ``pytest._code`` is **private** and **experimental**, so you definitely should not import it explicitly! Please note that the original ``py.code`` is still available in `pylib <http://pylib.readthedocs.org>`_. * ``pytest_enter_pdb`` now optionally receives the pytest config object. Thanks `@nicoddemus`_ for the PR. * Removed code and documentation for Python 2.5 or lower versions, including removal of the obsolete ``_pytest.assertion.oldinterpret`` module. Thanks `@nicoddemus`_ for the PR (`#1226`_). * Comparisons now always show up in full when ``CI`` or ``BUILD_NUMBER`` is found in the environment, even when ``-vv`` isn't used. Thanks `@The-Compiler`_ for the PR. * ``--lf`` and ``--ff`` now support long names: ``--last-failed`` and ``--failed-first`` respectively. Thanks `@MichaelAquilina`_ for the PR. * Added expected exceptions to ``pytest.raises`` fail message. * Collection only displays progress ("collecting X items") when in a terminal. This avoids cluttering the output when using ``--color=yes`` to obtain colors in CI integrations systems (`#1397`_). **Bug Fixes** * The ``-s`` and ``-c`` options should now work under ``xdist``; ``Config.fromdictargs`` now represents its input much more faithfully. Thanks to `@bukzor`_ for the complete PR (`#680`_). * Fix (`#1290`_): support Python 3.5's ``@`` operator in assertion rewriting. Thanks `@Shinkenjoe`_ for report with test case and `@tomviner`_ for the PR. * Fix formatting utf-8 explanation messages (`#1379`_). Thanks `@biern`_ for the PR. * Fix `traceback style docs`_ to describe all of the available options (auto/long/short/line/native/no), with `auto` being the default since v2.6. Thanks `@hackebrot`_ for the PR. * Fix (`#1422`_): junit record_xml_property doesn't allow multiple records with same name. .. _`traceback style docs`: https://pytest.org/latest/usage.html#modifying-python-traceback-printing .. _#1422: pytest-dev/pytest#1422 .. _#1379: pytest-dev/pytest#1379 .. _#1366: pytest-dev/pytest#1366 .. _#1040: pytest-dev/pytest#1040 .. _#680: pytest-dev/pytest#680 .. _#1287: pytest-dev/pytest#1287 .. _#1226: pytest-dev/pytest#1226 .. _#1290: pytest-dev/pytest#1290 .. _#1355: pytest-dev/pytest#1355 .. _#1397: pytest-dev/pytest#1397 .. _@biern: https://github.com/biern .. _@MichaelAquilina: https://github.com/MichaelAquilina .. _@bukzor: https://github.com/bukzor .. _@hpk42: https://github.com/hpk42 .. _@nicoddemus: https://github.com/nicoddemus .. _@jab: https://github.com/jab .. _@codewarrior0: https://github.com/codewarrior0 .. _@jaraco: https://github.com/jaraco .. _@The-Compiler: https://github.com/The-Compiler .. _@Shinkenjoe: https://github.com/Shinkenjoe .. _@tomviner: https://github.com/tomviner .. _@RonnyPfannschmidt: https://github.com/RonnyPfannschmidt .. _@rabbbit: https://github.com/rabbbit .. _@hackebrot: https://github.com/hackebrot
This was referenced Jul 26, 2016
This was referenced Aug 23, 2016
This was referenced Sep 23, 2016
This was referenced Sep 15, 2017
This was referenced Sep 29, 2017
This was referenced Oct 16, 2017
This was referenced Oct 29, 2017
This was referenced Nov 11, 2017
Merged
This was referenced Nov 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #469
A Node ID with all the components looks like this:
testing/test_skipping.py::TestSkipif::()::test_skipif_reporting_multiple[param-data-maybe-a-some-colons-::]This PR:
[, before splitting by::.pyonly when at end of file path