-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
None in paramtrized test id will use automatically generated id #1468
Merged
RonnyPfannschmidt
merged 7 commits into
pytest-dev:features
from
palaviv:allow-none-as-parametrized-test-id
Mar 20, 2016
Merged
None in paramtrized test id will use automatically generated id #1468
RonnyPfannschmidt
merged 7 commits into
pytest-dev:features
from
palaviv:allow-none-as-parametrized-test-id
Mar 20, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aker name for test
…arametrized-test-id
excellent work, as followup we might want to take a look at where to put the prefix |
RonnyPfannschmidt
added a commit
that referenced
this pull request
Mar 20, 2016
None in paramtrized test id will use automatically generated id
This was referenced Aug 24, 2016
This was referenced Aug 31, 2016
This was referenced Nov 15, 2017
Merged
This was referenced Nov 27, 2017
This was referenced Dec 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is allowing the user to pass None as a specific test id of parametrize. If a test id is None the specific test id will be automatically calculated.
This will result in the following tests:
As a side effect of this PR i noticed that when you pass the same test id we recieve a duplicate test:
Currently result in the test:
- test_a[a]
- test_a[a]
After this change the result will be:
- test_a[0a]
- test_a[1a]
Same as when a ids callable return the same value.