-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve idmaker name selection in case of duplicate ids in parametrize #1474
Improve idmaker name selection in case of duplicate ids in parametrize #1474
Conversation
@@ -26,7 +26,8 @@ | |||
* parametrize ids can accept None as specific test id. The | |||
automatically generated id for that argument will be used. | |||
|
|||
* | |||
* improved idmaker name selection in case of duplicate ids in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include a "thanks palaviv" and mention #1474. You might want to do the same for the item just above this one. 😉
It seems that the travis-ci failed because of some error unrelated to the tests:
Is there a way to rerun the build? |
I just restarted the failing build. |
Thanks again @palaviv! 😄 |
As @RonnyPfannschmidt mentioned in pull request #1468 the name selection in case of duplicate ids had some problems.
Let's take for example:
Before this change the tests names would be:
After this change: