Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pep440: replace lark in favour of regex #152

Merged
merged 2 commits into from
Mar 31, 2021

Conversation

abn
Copy link
Member

@abn abn commented Mar 30, 2021

The lark early implementation of PEP440 that was introduced was not
performant. The implementation added on average around 7 seconds to
the test suite execution time.

This change drops the lark parser, and uses packaging.version
provided regex for version string parsing. New dataclass interface for
version instances remain unaffected.

fyi: @sdispater

abn added 2 commits March 30, 2021 18:36
The lark early implementation of PEP440 that was introduced was not
performant. The implementation added on average around 7 seconds to
the test suite execution time.

This change drops the lark parser, and uses `packaging.version`
provided regex for version string parsing. New dataclass interface for
version instances remain unaffected.
@abn abn requested a review from a team March 30, 2021 16:37
@sdispater sdispater merged commit 8996496 into python-poetry:master Mar 31, 2021
@abn abn deleted the pep44/regex branch March 31, 2021 09:30
@sdispater sdispater mentioned this pull request Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants