Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poetry-core update with lark pep440 implementation #3831

Merged
merged 2 commits into from
Mar 27, 2021

Conversation

abn
Copy link
Member

@abn abn commented Mar 25, 2021

This change consumes the upstream changes to semver Version class implementation.

Relates-to: python-poetry/poetry-core#140
Relates-to: #2543
Relates-to: #1151
Relates-to: #892

@abn abn force-pushed the preview/poetry-core-semver branch from 43f7d86 to 9b88aed Compare March 26, 2021 23:43
@abn abn force-pushed the preview/poetry-core-semver branch from 9b88aed to cc0db46 Compare March 27, 2021 18:25
@abn abn changed the title preview: poetry-core update with lark pep440 poetry-core update with lark pep440 implementation Mar 27, 2021
@abn abn requested a review from a team March 27, 2021 19:27
@abn abn force-pushed the preview/poetry-core-semver branch from cc0db46 to 0fd839d Compare March 27, 2021 19:33
@abn abn marked this pull request as ready for review March 27, 2021 19:33
@abn abn merged commit 8c5611c into python-poetry:master Mar 27, 2021
@abn abn deleted the preview/poetry-core-semver branch March 27, 2021 19:41
@pinarkavak
Copy link

Why is this PR not put in the release 1.1.6?

@abn
Copy link
Member Author

abn commented May 27, 2021

@pinarkavak this is available in 1.2.0a1 and was not back ported to the 1.1.z stream as these only support bug fixes.

Also, do note that the lark usage was reverted in (python-poetry/poetry-core#152) due to performance concerns. However, the improvements to pep440 are still retained.

@pinarkavak
Copy link

Thank you.

Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants