pypa packaging compliance #402

abn · 2022-06-15T13:00:47Z

Resolves: python-poetry/poetry#7050

@radoering @neersighted stashing pandora's box here; thoughts welcome

sonarcloud · 2022-06-15T13:01:22Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

No Coverage information
0.0% Duplication

tests/semver/test_version_range.py

radoering

Some first comments. (I did not review all of it yet.) The changed and new tests look quite good.

Can we drop the first commit here please, because I think that's a separate topic and doesn't seem to influence the other changes?

tests/semver/test_version_range.py

src/poetry/core/semver/helpers.py

radoering

Next part of review. Some more todos in terms of code qualitiy, but functionally a good piece towards full PEP 440 compliance. 👍

src/poetry/core/version/pep440/version.py

src/poetry/core/version/pep440/segments.py

src/poetry/core/semver/version_range_constraint.py

src/poetry/core/semver/version_range.py

radoering · 2022-10-11T16:12:34Z

Rebased on current main and dropped first commit because it was controversial, not related to pypa packaging compliance and tracked in #399 anyway.

sonarcloud · 2022-10-11T17:58:19Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

radoering

There might be an issue with pre-release-handling:

Without this PR, something like "==3.8.*" is parsed to ">=3.8,<3.9".
With this PR, it is parsed to ">=3.8.dev0,<3.9".

Although considered on its own, the latter is more correct, it implicitly sets allow_prereleases:

poetry-core/src/poetry/core/packages/dependency.py

Lines 79 to 81 in 0759db6

    
           allows_prereleases = ( 
        
               allows_prereleases or self._constraint.min.is_unstable() 
        
           )

That's probably not desired behavior.

Update: fixed via #543

sonarcloud · 2022-12-22T11:58:13Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

sonarcloud · 2023-01-23T16:33:22Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

#7852)

Co-authored-by: Randy Döring <30527984+radoering@users.noreply.github.com>

…=1.2.*")

sonarcloud · 2023-05-08T14:37:00Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

…#402

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [poetry](https://python-poetry.org/) ([source](https://github.com/python-poetry/poetry), [changelog](https://python-poetry.org/history/)) | minor | `1.4.2` -> `1.5.0` | --- ### Release Notes <details> <summary>python-poetry/poetry</summary> ### [`v1.5.0`](https://github.com/python-poetry/poetry/blob/HEAD/CHANGELOG.md#150---2023-05-19) [Compare Source](python-poetry/poetry@1.4.2...1.5.0) ##### Added - **Introduce the new source priorities `explicit` and `supplemental`** ([#7658](python-poetry/poetry#7658), [#6879](python-poetry/poetry#6879)). - **Introduce the option to configure the priority of the implicit PyPI source** ([#7801](python-poetry/poetry#7801)). - Add handling for corrupt cache files ([#7453](python-poetry/poetry#7453)). - Improve caching of URL and git dependencies ([#7693](python-poetry/poetry#7693), [#7473](python-poetry/poetry#7473)). - Add option to skip installing directory dependencies ([#6845](python-poetry/poetry#6845), [#7923](python-poetry/poetry#7923)). - Add `--executable` option to `poetry env info` ([#7547](python-poetry/poetry#7547)). - Add `--top-level` option to `poetry show` ([#7415](python-poetry/poetry#7415)). - Add `--lock` option to `poetry remove` ([#7917](python-poetry/poetry#7917)). - Add experimental `POETRY_REQUESTS_TIMEOUT` option ([#7081](python-poetry/poetry#7081)). - Improve performance of wheel inspection by avoiding unnecessary file copy operations ([#7916](python-poetry/poetry#7916)). ##### Changed - **Remove the old deprecated installer and the corresponding setting `experimental.new-installer`** ([#7356](python-poetry/poetry#7356)). - **Introduce `priority` key for sources and deprecate flags `default` and `secondary`** ([#7658](python-poetry/poetry#7658)). - Deprecate `poetry run <entry point>` if the entry point was not previously installed via `poetry install` ([#7606](python-poetry/poetry#7606)). - Only write the lock file if the installation succeeds ([#7498](python-poetry/poetry#7498)). - Do not write the unused package category into the lock file ([#7637](python-poetry/poetry#7637)). ##### Fixed - Fix an issue where Poetry's internal pyproject.toml continually grows larger with empty lines ([#7705](python-poetry/poetry#7705)). - Fix an issue where Poetry crashes due to corrupt cache files ([#7453](python-poetry/poetry#7453)). - Fix an issue where the `Retry-After` in HTTP responses was not respected and retries were handled inconsistently ([#7072](python-poetry/poetry#7072)). - Fix an issue where Poetry silently ignored invalid groups ([#7529](python-poetry/poetry#7529)). - Fix an issue where Poetry does not find a compatible Python version if not given explicitly ([#7771](python-poetry/poetry#7771)). - Fix an issue where the `direct_url.json` of an editable install from a git dependency was invalid ([#7473](python-poetry/poetry#7473)). - Fix an issue where error messages from build backends were not decoded correctly ([#7781](python-poetry/poetry#7781)). - Fix an infinite loop when adding certain dependencies ([#7405](python-poetry/poetry#7405)). - Fix an issue where pre-commit hooks skip pyproject.toml files in subdirectories ([#7239](python-poetry/poetry#7239)). - Fix an issue where pre-commit hooks do not use the expected Python version ([#6989](python-poetry/poetry#6989)). - Fix an issue where an unclear error message is printed if the project name is the same as one of its dependencies ([#7757](python-poetry/poetry#7757)). - Fix an issue where `poetry install` returns a zero exit status even though the build script failed ([#7812](python-poetry/poetry#7812)). - Fix an issue where an existing `.venv` was not used if `in-project` was not set ([#7792](python-poetry/poetry#7792)). - Fix an issue where multiple extras passed to `poetry add` were not parsed correctly ([#7836](python-poetry/poetry#7836)). - Fix an issue where `poetry shell` did not send a newline to `fish` ([#7884](python-poetry/poetry#7884)). - Fix an issue where `poetry update --lock` printed operations that were not executed ([#7915](python-poetry/poetry#7915)). - Fix an issue where `poetry add --lock` did perform a full update of all dependencies ([#7920](python-poetry/poetry#7920)). - Fix an issue where `poetry shell` did not work with `nushell` ([#7919](python-poetry/poetry#7919)). - Fix an issue where subprocess calls failed on Python 3.7 ([#7932](python-poetry/poetry#7932)). - Fix an issue where keyring was called even though the password was stored in an environment variable ([#7928](python-poetry/poetry#7928)). ##### Docs - Add information about what to use instead of `--dev` ([#7647](python-poetry/poetry#7647)). - Promote semantic versioning less aggressively ([#7517](python-poetry/poetry#7517)). - Explain Poetry's own versioning scheme in the FAQ ([#7517](python-poetry/poetry#7517)). - Update documentation for configuration with environment variables ([#6711](python-poetry/poetry#6711)). - Add details how to disable the virtualenv prompt ([#7874](python-poetry/poetry#7874)). - Improve documentation on whether to commit `poetry.lock` ([#7506](python-poetry/poetry#7506)). - Improve documentation of `virtualenv.create` ([#7608](python-poetry/poetry#7608)). ##### poetry-core ([`1.6.0`](https://github.com/python-poetry/poetry-core/releases/tag/1.6.0)) - Improve error message for invalid markers ([#569](python-poetry/poetry-core#569)). - Increase robustness when deleting temporary directories on Windows ([#460](python-poetry/poetry-core#460)). - Replace `tomlkit` with `tomli`, which changes the interface of some *internal* classes ([#483](python-poetry/poetry-core#483)). - Deprecate `Package.category` ([#561](python-poetry/poetry-core#561)). - Fix a performance regression in marker handling ([#568](python-poetry/poetry-core#568)). - Fix an issue where wildcard version constraints were not handled correctly ([#402](python-poetry/poetry-core#402)). - Fix an issue where `poetry build` created duplicate Python classifiers if they were specified manually ([#578](python-poetry/poetry-core#578)). - Fix an issue where local versions where not handled correctly ([#579](python-poetry/poetry-core#579)). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.walbeck.it/walbeck-it/docker-python-poetry/pulls/717 Co-authored-by: renovate-bot <bot@walbeck.it> Co-committed-by: renovate-bot <bot@walbeck.it>

abn commented Jun 15, 2022

View reviewed changes

tests/semver/test_version_range.py Outdated Show resolved Hide resolved

radoering requested changes Jun 17, 2022

View reviewed changes

radoering requested changes Jun 19, 2022

View reviewed changes

radoering mentioned this pull request Oct 11, 2022

In version-constraints prefix-matching (with .*) is not respected after a pre-release version python-poetry/poetry#6774

Closed

4 tasks

radoering force-pushed the pypa-packaging-compliance branch from 511d168 to 77cada3 Compare October 11, 2022 16:10

radoering force-pushed the pypa-packaging-compliance branch from 77cada3 to e088c1b Compare October 11, 2022 16:17

radoering requested changes Oct 15, 2022

View reviewed changes

radoering mentioned this pull request Nov 17, 2022

Poetry & PEP440 Disagree on an example in the PEP. python-poetry/poetry#7050

Closed

4 tasks

radoering mentioned this pull request Dec 20, 2022

repository: PEP 440 pre-release handling python-poetry/poetry#7225

Merged

2 tasks

radoering force-pushed the pypa-packaging-compliance branch from 74bc75f to 83d8862 Compare December 22, 2022 11:57

radoering mentioned this pull request Dec 22, 2022

PEP 440 compliance: do not implicitly allow pre-releases #543

Merged

radoering force-pushed the pypa-packaging-compliance branch from 83d8862 to dea1495 Compare January 23, 2023 16:32

radoering force-pushed the pypa-packaging-compliance branch 3 times, most recently from 3a4aff1 to 9a5defe Compare April 30, 2023 11:58

radoering added a commit to radoering/poetry that referenced this pull request Apr 30, 2023

tests: ensure forward compatibility with python-poetry/poetry-core#402

24fe4c2

This was referenced Apr 30, 2023

tests: ensure forward compatibility with python-poetry/poetry-core#402 python-poetry/poetry#7852

Merged

1.5.0 Release python-poetry/poetry#7853

Closed

radoering added a commit to radoering/poetry that referenced this pull request May 5, 2023

tests: ensure forward compatibility with python-poetry/poetry-core#402

6e3295c

radoering added a commit to radoering/poetry that referenced this pull request May 5, 2023

tests: ensure forward compatibility with python-poetry/poetry-core#402

14b7b8d

radoering added a commit to radoering/poetry that referenced this pull request May 8, 2023

tests: ensure forward compatibility with python-poetry/poetry-core#402

76c8335

radoering added a commit to radoering/poetry that referenced this pull request May 8, 2023

tests: ensure forward compatibility with python-poetry/poetry-core#402

b5ca629

radoering added a commit to python-poetry/poetry that referenced this pull request May 8, 2023

tests: ensure forward compatibility with python-poetry/poetry-core#402 (

a27d35e

#7852)

abn and others added 2 commits May 8, 2023 16:36

pypa/packaging compliance (especially wildcard constraints)

87da204

Co-authored-by: Randy Döring <30527984+radoering@users.noreply.github.com>

improve handling of single wildcard ranges (e.g. "==1.2.*")

0dfdee0

radoering added 2 commits May 8, 2023 16:36

fix and simplify handling of single wildcard range exclusion (e.g. "!…

4aa943a

…=1.2.*")

tests: sort tests and increase coverage

8746e1d

radoering force-pushed the pypa-packaging-compliance branch from 9a5defe to 8746e1d Compare May 8, 2023 14:36

radoering marked this pull request as ready for review May 8, 2023 14:59

radoering approved these changes May 8, 2023

View reviewed changes

radoering merged commit c87a764 into python-poetry:main May 8, 2023

radoering added a commit to radoering/poetry-core that referenced this pull request May 11, 2023

performance: fix a performance regression introduced in python-poetry…

19492bb

…#402

radoering mentioned this pull request May 11, 2023

performance: fix a performance regression introduced in #402 #582

Merged

radoering added a commit that referenced this pull request May 12, 2023

performance: fix a performance regression introduced in #402 (#582)

f93c93a

This was referenced May 12, 2023

release: bump version to 1.6.0 #584

Merged

release: bump version to 1.5.0 python-poetry/poetry#7947

Merged

d-ryan-ashcraft mentioned this pull request Jun 9, 2023

Update minimum supported Poetry version to be 1.5.0 TechnologyBrewery/habushu#27

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pypa packaging compliance #402

pypa packaging compliance #402

abn commented Jun 15, 2022 •

edited by radoering

Loading

sonarcloud bot commented Jun 15, 2022

radoering left a comment

radoering left a comment

radoering commented Oct 11, 2022

sonarcloud bot commented Oct 11, 2022

radoering left a comment •

edited

Loading

sonarcloud bot commented Dec 22, 2022

sonarcloud bot commented Jan 23, 2023

sonarcloud bot commented May 8, 2023

	allows_prereleases = (
	allows_prereleases or self._constraint.min.is_unstable()
	)

pypa packaging compliance #402

pypa packaging compliance #402

Conversation

abn commented Jun 15, 2022 • edited by radoering Loading

sonarcloud bot commented Jun 15, 2022

radoering left a comment

Choose a reason for hiding this comment

radoering left a comment

Choose a reason for hiding this comment

radoering commented Oct 11, 2022

sonarcloud bot commented Oct 11, 2022

radoering left a comment • edited Loading

Choose a reason for hiding this comment

sonarcloud bot commented Dec 22, 2022

sonarcloud bot commented Jan 23, 2023

sonarcloud bot commented May 8, 2023

abn commented Jun 15, 2022 •

edited by radoering

Loading

radoering left a comment •

edited

Loading