Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: ensure forward compatibility with python-poetry/poetry-core#402 #7852

Merged
merged 3 commits into from
May 8, 2023

Conversation

radoering
Copy link
Member

With python-poetry/poetry-core#402 the constraint ">= 2.8.1, == 2.8.*" is parsed to ">=2.8.1,<2.9.dev0" instead of ">=2.8.1,<2.9.0".

All three are equivalent according to PEP 440.

I added some more options (considering zero padding) to make the test more robust to possible future changes.

@radoering radoering mentioned this pull request Apr 30, 2023
@radoering radoering requested a review from a team May 5, 2023 04:47
Copy link
Member

@Secrus Secrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question and one nitpick

tests/utils/test_dependency_specification.py Outdated Show resolved Hide resolved
tests/utils/test_dependency_specification.py Outdated Show resolved Hide resolved
@radoering radoering enabled auto-merge (squash) May 8, 2023 14:25
@radoering radoering merged commit a27d35e into python-poetry:master May 8, 2023
Copy link

github-actions bot commented Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
@radoering radoering deleted the pypa-packaging-compliance branch November 24, 2024 12:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants