fix: poetry env broken on Windows (#4615)
#4682
Conversation
|
@sdispater - this is a trivial fix and the problem is quite severe on Windows. |
|
@tom-bowles can you rebase this so the cirrus tests can have a rerun please? |
|
@abn - Thanks for taking a look! I've rebased now. |
|
@tom-bowles should have mentioned this earlier, any cance we can add in a test case for this so we do not regress? |
|
@abn - no worries, I'll have a crack at that today |
|
@abn - Added test. |
|
|
||
| venv = VirtualEnv(venv_path) | ||
|
|
||
| assert Path(venv.python) == base_dir_path |
There was a problem hiding this comment.
Looks like this test fails on Python 3.6 on Windows, so I spoke a little too soon. Can we take a look at that failure and get it corrected?
(Also includes correction for non-mingw Windows from python-poetry#4682)
|
Looks like this was fixed incidentally at #5007. Apparently that one was allowed through without testcases so I suppose it could just about be worth keeping this open if anyone is motivated, more than a year later, to add a unit test. But I expect this should now be closed. |
Resolves: #4615
Looks like this if statement was copied from further up in the function and only one of the branches updated to use self._path.