Fix: conda environment is detected as broken (#4566)

[finswimmer]

conda puts the python and pip executable on windows in different location. So poetry is unable to detect a valid venv. This PR fixes this.

There is also a port for 1.1: #5008

Resolves: #4566

[zEdS15B3GCwq]

Some ideas off the top of my head. Sorry if I'm wrong.

From the original env.py > Env > _bin code:

        if self._is_windows and not bin.endswith(".exe"):
            bin_path = self._bin_dir / (bin + ".exe")
        else:
            bin_path = self._bin_dir / bin

        if not bin_path.exists():
            # On Windows, some executables can be in the base path
            # This is especially true when installing Python with
            # the official installer, where python.exe will be at
            # the root of the env path.
            if self._is_windows:
                if not bin.endswith(".exe"):
                    bin_path = self._bin_dir / (bin + ".exe")  # <<< bug?
                else:
                    bin_path = self._path / bin

I have a feeling that the inside bin_path = self._bin_dir / (bin + ".exe") is a bug - it's already handled, it's known that it doesn't exist. Shouldn't it be bin_path = self._path / (bin + ".exe")? Also, self._path == self._bin_dir.parent, so a simple fix covers the same case as your patch:

        if not bin_path.exists():
            # On Windows, some executables can be in the base path
            # This is especially true when installing Python with
            # the official installer, where python.exe will be at
            # the root of the env path.
            if self._is_windows:
                if not bin.endswith(".exe"):
                    bin_path = self._path / (bin + ".exe")  # <<< fixed?
                else:
                    bin_path = self._path / bin

[zEdS15B3GCwq]

On the same note, in find_executables, perhaps

    def find_executables(self) -> None:
        if self._is_windows and self._is_conda:
            python_bin_dir = self._bin_dir.parent
        else:
            python_bin_dir = self._bin_dir

could be

    def find_executables(self) -> None:
        if self._is_windows and self._is_conda:
            python_bin_dir = self._path  # <<< this?
        else:
            python_bin_dir = self._bin_dir

[finswimmer]

Thanks a lot for your feedback @zEdS15B3GCwq. 👍

I'm aware that there are some ugly parts that should be improved. That's why its a draft pr and I called it a proof-of-concept. Once I get some feedback in the corresponding issue whether it works as expected or not I will start improving the code.

fin swimmer

[zEdS15B3GCwq]

sorry, ignore this

[finswimmer]

sorry, ignore this

No, I will not. You've given some good points 😃

[zEdS15B3GCwq]

sorry, ignore this

No, I will not. You've given some good points 😃

That's nice of you, but I meant that particular message (or did you known already).

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.