-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve test_inspect
#103553
Comments
sobolevn
added
type-bug
An unexpected behavior, bug, or error
tests
Tests in the Lib/test dir
labels
Apr 15, 2023
sobolevn
added a commit
to sobolevn/cpython
that referenced
this issue
Apr 15, 2023
hauntsaninja
pushed a commit
that referenced
this issue
Apr 15, 2023
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Apr 15, 2023
…unused (pythonGH-103554) (cherry picked from commit 4fe1c4b) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington
added a commit
that referenced
this issue
Apr 15, 2023
…GH-103554) (cherry picked from commit 4fe1c4b) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
carljm
added a commit
to carljm/cpython
that referenced
this issue
Apr 17, 2023
* main: Remove `expert-*` from `project-updater` GH workflow (python#103579) pythongh-103583: Add codecs and maps to _codecs_* module state (python#103540) pythongh-48330: address review comments to PR-12271 (python#103209) pythongh-103527: Add multibytecodec.h as make dep for _codecs_* (python#103567) pythongh-103553: Improve `test_inspect`: add more assertions, remove unused (python#103554) pythonGH-103517: Improve tests for `pathlib.Path.walk()` (pythonGH-103518) pythongh-102114: Make dis print more concise tracebacks for syntax errors in str inputs (python#102115) pythonGH-78079: Fix UNC device path root normalization in pathlib (pythonGH-102003) pythongh-101517: Add regression test for a lineno bug in try/except* impacting pdb (python#103547) pythongh-103527: Add make deps for _codecs_* and _multibytecodec (python#103528) pythongh-103532: Fix reST syntax in NEWS entry (pythonGH-103544) pythongh-103532: Add NEWS entry (python#103542)
carljm
added a commit
to carljm/cpython
that referenced
this issue
Apr 17, 2023
* superopt: update generated cases with new comment review comments Remove `expert-*` from `project-updater` GH workflow (python#103579) pythongh-103583: Add codecs and maps to _codecs_* module state (python#103540) pythongh-48330: address review comments to PR-12271 (python#103209) pythongh-103527: Add multibytecodec.h as make dep for _codecs_* (python#103567) pythongh-103553: Improve `test_inspect`: add more assertions, remove unused (python#103554) pythonGH-103517: Improve tests for `pathlib.Path.walk()` (pythonGH-103518) pythongh-102114: Make dis print more concise tracebacks for syntax errors in str inputs (python#102115) pythonGH-78079: Fix UNC device path root normalization in pathlib (pythonGH-102003) pythongh-101517: Add regression test for a lineno bug in try/except* impacting pdb (python#103547) pythongh-103527: Add make deps for _codecs_* and _multibytecodec (python#103528) pythongh-103532: Fix reST syntax in NEWS entry (pythonGH-103544) pythongh-103532: Add NEWS entry (python#103542)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While working on #103406 I've noticed that there are some problems with
test_inspect
that we can easily fix.List of problems I found:
cpython/Lib/test/test_inspect.py
Lines 1840 to 1845 in 2b6f5c3
f4
is not ever used, butf3
has duplicate asserts. It looks like a copy-paste error to me. I propose to add asserts forf4
as wellcpython/Lib/test/test_inspect.py
Lines 1835 to 1838 in 2b6f5c3
cpython/Lib/test/test_inspect.py
Lines 1823 to 1824 in 2b6f5c3
cpython/Lib/test/test_inspect.py
Line 2991 in 2b6f5c3
cpython/Lib/test/test_inspect.py
Lines 2987 to 2989 in 2b6f5c3
Here's my PR :)
Linked PRs
test_inspect
: add more assertions, remove unused #103554test_inspect
: add more assertions, remove unused (GH-103554) #103568The text was updated successfully, but these errors were encountered: