Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove expert-* from project-updater GH workflow #103579

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Conversation

ezio-melotti
Copy link
Member

The expert-* labels are being renamed to topic-*, breaking the project-updater workflow. In the meanwhile GitHub also added a project workflow to automatically add issues (and PRs) to a project, that might be used to replace the workflow entirely.

I now updated both the Subinterpreters and Asyncio projects and enable to auto-add workflow, so we can safely remove them from here. Eventually we might get rid of the workflow altogether.

See:

The `expert-*` labels are being renamed and the project workflow can now be used to auto-add issues to projects, so they can be removed from here.
@ezio-melotti ezio-melotti added skip issue skip news 3.11 only security fixes 3.12 bugs and security fixes needs backport to 3.11 only security fixes 3.13 bugs and security fixes labels Apr 16, 2023
@ezio-melotti ezio-melotti requested a review from hugovk as a code owner April 16, 2023 17:29
@ezio-melotti ezio-melotti self-assigned this Apr 16, 2023
@sobolevn sobolevn mentioned this pull request Apr 16, 2023
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that everything works without these lines: I've opened a test issue #103580

It was correctly handled.
Снимок экрана 2023-04-16 в 21 02 01
Снимок экрана 2023-04-16 в 21 02 29

Thank you! 👍

@miss-islington
Copy link
Contributor

Thanks @ezio-melotti for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @ezio-melotti and @hugovk, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 76933df10afc958b2db2a6bcff7509285fbf5fcf 3.11

@ezio-melotti ezio-melotti deleted the remove-expert-labels branch April 17, 2023 03:33
@hugovk
Copy link
Member

hugovk commented Apr 17, 2023

There's no .github/workflows/project-updater.yml in the 3.11 branch:

https://github.com/python/cpython/tree/main/.github/workflows

@ezio-melotti ezio-melotti removed 3.11 only security fixes needs backport to 3.11 only security fixes labels Apr 17, 2023
carljm added a commit to carljm/cpython that referenced this pull request Apr 17, 2023
* main:
  Remove `expert-*` from `project-updater` GH workflow (python#103579)
  pythongh-103583: Add codecs and maps to _codecs_* module state (python#103540)
  pythongh-48330: address review comments to PR-12271 (python#103209)
  pythongh-103527: Add multibytecodec.h as make dep for _codecs_* (python#103567)
  pythongh-103553: Improve `test_inspect`: add more assertions, remove unused (python#103554)
  pythonGH-103517: Improve tests for `pathlib.Path.walk()` (pythonGH-103518)
  pythongh-102114: Make dis print more concise tracebacks for syntax errors in str inputs (python#102115)
  pythonGH-78079: Fix UNC device path root normalization in pathlib (pythonGH-102003)
  pythongh-101517: Add regression test for a lineno bug in try/except* impacting pdb (python#103547)
  pythongh-103527: Add make deps for _codecs_* and _multibytecodec (python#103528)
  pythongh-103532: Fix reST syntax in NEWS entry (pythonGH-103544)
  pythongh-103532: Add NEWS entry (python#103542)
carljm added a commit to carljm/cpython that referenced this pull request Apr 17, 2023
* superopt:
  update generated cases with new comment
  review comments
  Remove `expert-*` from `project-updater` GH workflow (python#103579)
  pythongh-103583: Add codecs and maps to _codecs_* module state (python#103540)
  pythongh-48330: address review comments to PR-12271 (python#103209)
  pythongh-103527: Add multibytecodec.h as make dep for _codecs_* (python#103567)
  pythongh-103553: Improve `test_inspect`: add more assertions, remove unused (python#103554)
  pythonGH-103517: Improve tests for `pathlib.Path.walk()` (pythonGH-103518)
  pythongh-102114: Make dis print more concise tracebacks for syntax errors in str inputs (python#102115)
  pythonGH-78079: Fix UNC device path root normalization in pathlib (pythonGH-102003)
  pythongh-101517: Add regression test for a lineno bug in try/except* impacting pdb (python#103547)
  pythongh-103527: Add make deps for _codecs_* and _multibytecodec (python#103528)
  pythongh-103532: Fix reST syntax in NEWS entry (pythonGH-103544)
  pythongh-103532: Add NEWS entry (python#103542)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.12 bugs and security fixes 3.13 bugs and security fixes skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants