Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDLE - Remove unneeded .keys for dict iteration #103737

Closed
terryjreedy opened this issue Apr 24, 2023 · 0 comments
Closed

IDLE - Remove unneeded .keys for dict iteration #103737

terryjreedy opened this issue Apr 24, 2023 · 0 comments
Assignees
@terryjreedy
Labels
topic-IDLE

Comments

@terryjreedy
Copy link
Member

terryjreedy commented Apr 24, 2023 •
edited by bedevere-app bot
Loading

Issue #87179, item 6. At the moment, ob.keys() appears 16 times in idlelib. Sometimes 'ob' is a dict, in which case '.keys()' can be removed. Sometimes ob is not a dict, and possibly not an iterable, and '.keys()' returns an iterable other than a dict keys view. In some such cases I am adding a note as to what the return value is to be clear that '.keys()' is needed.

Sometimes func(somedict) (list or tuple or set or ?) is needed because an immediate iteration will modify the dict or the captured keys will be sent elsewhere, such as through the rpc connection, or the keys are transformed, as with sorted.

Linked PRs
@terryjreedy terryjreedy self-assigned this Apr 24, 2023
@terryjreedy terryjreedy mentioned this issue Oct 15, 2023
Closed
terryjreedy added a commit to terryjreedy/cpython that referenced this issue Oct 17, 2023
@terryjreedy
pythongh-103737: IDLE - Removes unneeded .keys() for dict iteration.
7bb15ec 
Comment some of non-dict .keys() returns.

config: remove .keys(), fix dump, add comments.
debugobj: remove one .keys()

test_config: remove .keys()
test_debugobj: comment .keys() returns
@bedevere-app bedevere-app bot mentioned this issue Oct 17, 2023
Merged
terryjreedy added a commit that referenced this issue Oct 18, 2023
@terryjreedy
gh-103737: IDLE - Remove unneeded .keys() for dict iteration (#110960)
baefbb2 
Add comments where .keys() is needed.
Leave debugger usages along because situation is unclear as indicated in expanded comment.
Most testing is manual.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 18, 2023
@terryjreedy @miss-islington
pythongh-103737: IDLE - Remove unneeded .keys() for dict iteration (p…
a0586a8 
…ythonGH-110960)

Add comments where .keys() is needed.
Leave debugger usages along because situation is unclear as indicated in expanded comment.
Most testing is manual.
(cherry picked from commit baefbb2)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@bedevere-app bedevere-app bot mentioned this issue Oct 18, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 18, 2023
@terryjreedy @miss-islington
pythongh-103737: IDLE - Remove unneeded .keys() for dict iteration (p…
53e46fd 
…ythonGH-110960)

Add comments where .keys() is needed.
Leave debugger usages along because situation is unclear as indicated in expanded comment.
Most testing is manual.
(cherry picked from commit baefbb2)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@bedevere-app bedevere-app bot mentioned this issue Oct 18, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 18, 2023
@terryjreedy @miss-islington
pythongh-103737: IDLE - Remove unneeded .keys() for dict iteration (p…
3b041d7 
…ythonGH-110960)

Add comments where .keys() is needed.
Leave debugger usages along because situation is unclear as indicated in expanded comment.
Most testing is manual.
(cherry picked from commit baefbb2)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
terryjreedy added a commit that referenced this issue Oct 18, 2023
@miss-islington @terryjreedy
[3.11] gh-103737: IDLE - Remove unneeded .keys() for dict iteration (G…
7c308f4 
…H-110960) (#111027)

gh-103737: IDLE - Remove unneeded .keys() for dict iteration (GH-110960)

Add comments where .keys() is needed.
Leave debugger usages along because situation is unclear as indicated in expanded comment.
Most testing is manual.
(cherry picked from commit baefbb2)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
terryjreedy added a commit that referenced this issue Oct 18, 2023
@miss-islington @terryjreedy
[3.12] gh-103737: IDLE - Remove unneeded .keys() for dict iteration (G…
b8ce5d9 
…H-110960) (#111026)

gh-103737: IDLE - Remove unneeded .keys() for dict iteration (GH-110960)

Add comments where .keys() is needed.
Leave debugger usages along because situation is unclear as indicated in expanded comment.
Most testing is manual.
(cherry picked from commit baefbb2)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@terryjreedy @aisk
pythongh-103737: IDLE - Remove unneeded .keys() for dict iteration (p…
233a85f 
…ython#110960)

Add comments where .keys() is needed.
Leave debugger usages along because situation is unclear as indicated in expanded comment.
Most testing is manual.
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@terryjreedy @Glyphack
pythongh-103737: IDLE - Remove unneeded .keys() for dict iteration (p…
a942be6 
…ython#110960)

Add comments where .keys() is needed.
Leave debugger usages along because situation is unclear as indicated in expanded comment.
Most testing is manual.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terryjreedy terryjreedy

Labels
topic-IDLE
Projects
IDLE Issues
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@terryjreedy