gh-103737: IDLE - Remove unneeded .keys() for dict iteration #110960
Merged
+28
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment some of non-dict .keys() returns. config: remove .keys(), fix dump, add comments. debugobj: remove one .keys() test_config: remove .keys() test_debugobj: comment .keys() returns
debugger: must verify note, added TODO debugger_r: must verify note pyshell: dict changed in iteration stackviewer: object possibly not dict
Tested without .keys(). Add note about removing sort numbers later.
Tested Keys action-keys list still present and sorted.
editor.py 1028 already has 'for instance in ... instance_dict. Also tested that can change keys.
terryjreedy
added
skip news
needs backport to 3.11
|
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 18, 2023
…ythonGH-110960) Add comments where .keys() is needed. Leave debugger usages along because situation is unclear as indicated in expanded comment. Most testing is manual. (cherry picked from commit baefbb2) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 18, 2023
…ythonGH-110960) Add comments where .keys() is needed. Leave debugger usages along because situation is unclear as indicated in expanded comment. Most testing is manual. (cherry picked from commit baefbb2) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
|
GH-111026 is a backport of this pull request to the 3.12 branch. |
|
GH-111027 is a backport of this pull request to the 3.11 branch. |
|
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 18, 2023
…ythonGH-110960) Add comments where .keys() is needed. Leave debugger usages along because situation is unclear as indicated in expanded comment. Most testing is manual. (cherry picked from commit baefbb2) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
terryjreedy
added a commit
that referenced
this pull request
Oct 18, 2023
…H-110960) (#111027) gh-103737: IDLE - Remove unneeded .keys() for dict iteration (GH-110960) Add comments where .keys() is needed. Leave debugger usages along because situation is unclear as indicated in expanded comment. Most testing is manual. (cherry picked from commit baefbb2) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
terryjreedy
added a commit
that referenced
this pull request
Oct 18, 2023
…H-110960) (#111026) gh-103737: IDLE - Remove unneeded .keys() for dict iteration (GH-110960) Add comments where .keys() is needed. Leave debugger usages along because situation is unclear as indicated in expanded comment. Most testing is manual. (cherry picked from commit baefbb2) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…ython#110960) Add comments where .keys() is needed. Leave debugger usages along because situation is unclear as indicated in expanded comment. Most testing is manual.
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…ython#110960) Add comments where .keys() is needed. Leave debugger usages along because situation is unclear as indicated in expanded comment. Most testing is manual.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add comments where .keys() is needed.
Leave debugger usages along because situation is unclear as indicated in expanded comment.
Most testing is manual.