Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_typing.NewTypeTests can be improved #105431

Closed
sobolevn opened this issue Jun 7, 2023 · 0 comments
Closed

test_typing.NewTypeTests can be improved #105431

sobolevn opened this issue Jun 7, 2023 · 0 comments
Assignees
@sobolevn
Labels
tests Tests in the Lib/test dir topic-typing type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented Jun 7, 2023 •
edited by bedevere-bot
Loading

After https://github.com/python/cpython/pull/103764/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305dR6452 NewTypeTests has two unused methods:

  • cleanup, it is even provided in its parent class: BaseTestCase
  • teardown, because it does not need to clean things up, tests with -R 3:3 prove that

I will send a PR to clean things up.

Linked PRs
@sobolevn sobolevn added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir topic-typing labels Jun 7, 2023
@sobolevn sobolevn self-assigned this Jun 7, 2023
@bedevere-bot bedevere-bot mentioned this issue Jun 7, 2023
Merged
sobolevn added a commit to sobolevn/cpython that referenced this issue Jun 7, 2023
@sobolevn
pythongh-105431: Remove unused stuff from test_typing.NewTypeTests
e444cfc
AlexWaygood pushed a commit that referenced this issue Jun 8, 2023
@sobolevn
gh-105431: Remove unused stuff from test_typing.NewTypeTests (#105432)
9d35a71
@bedevere-bot bedevere-bot mentioned this issue Jun 8, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 8, 2023
@sobolevn @miss-islington
pythongh-105431: Remove unused stuff from test_typing.NewTypeTests (p…
ec713b8 
…ythonGH-105432)

(cherry picked from commit 9d35a71)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
AlexWaygood pushed a commit that referenced this issue Jun 8, 2023
@miss-islington @sobolevn
[3.12] gh-105431: Remove unused stuff from test_typing.NewTypeTests (…
2b6f475 
…GH-105432) (#105489)

gh-105431: Remove unused stuff from `test_typing.NewTypeTests` (GH-105432)
(cherry picked from commit 9d35a71)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
tests Tests in the Lib/test dir topic-typing type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sobolevn @AlexWaygood