-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-105431: Remove unused stuff from test_typing.NewTypeTests
#105432
Conversation
🤖 New build scheduled with the buildbot fleet by @AlexWaygood for commit e444cfc 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
The refleak buildbots haven't run for some reason, and I would like to make sure we get a refleak buildbot run before merging this, since it's basically a revert of #27305, which was a PR to fix refleaks in Marking as do-not-merge until we've had a refleak buildbot run. |
Local result:
|
I believe you, but I'd still like to make sure that we get the same results in CI before merging :) |
🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit e444cfc 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good assuming the buildbots eventually wake up
🤖 New build scheduled with the buildbot fleet by @AlexWaygood for commit e444cfc 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The refleak buildbot results are finally in, and they look good. There's no failures in test_typing
, just pre-existing refleaks in test_capi
.
Thanks!
Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
GH-105489 is a backport of this pull request to the 3.12 branch. |
…ythonGH-105432) (cherry picked from commit 9d35a71) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
…GH-105432) (#105489) gh-105431: Remove unused stuff from `test_typing.NewTypeTests` (GH-105432) (cherry picked from commit 9d35a71) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
test_typing.NewTypeTests
can be improved #105431