Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused imports from the stdlib #120417

Closed
vstinner opened this issue Jun 12, 2024 · 8 comments
Closed

Remove unused imports from the stdlib #120417

vstinner opened this issue Jun 12, 2024 · 8 comments

Comments

@vstinner
Copy link
Member

vstinner commented Jun 12, 2024 •
edited by bedevere-app bot
Loading

Using pyflakes or ruff, I found unused imports and I created this issue to remove them.

Linked PRs
vstinner added a commit to vstinner/cpython that referenced this issue Jun 12, 2024
@vstinner
pythongh-120417: Remove unused imports in the stdlib
3a04487
vstinner added a commit to vstinner/cpython that referenced this issue Jun 12, 2024
@vstinner
pythongh-120417: Remove unused imports in the stdlib
0befb7b
@bedevere-app bedevere-app bot mentioned this issue Jun 12, 2024
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Jun 12, 2024
@vstinner
pythongh-120417: Add #noqa to used imports to prevent warnings
28cf6b1 
Tools such as ruff can ignore 'imported but unused' warnings if a
line ends with "# noqa". It prevents the temptation to remove an
import which is used effectively.
vstinner added a commit to vstinner/cpython that referenced this issue Jun 12, 2024
@vstinner
pythongh-120417: Add #noqa to used imports in the stdlib
f6d03d4 
Tools such as ruff can ignore 'imported but unused' warnings if a
line ends with "# noqa". It prevents the temptation to remove an
import which is used effectively.
vstinner added a commit to vstinner/cpython that referenced this issue Jun 12, 2024
@vstinner
pythongh-120417: Add #noqa to used imports in the stdlib
119f192 
Tools such as ruff can ignore 'imported but unused' warnings if a
line ends with "# noqa". It prevents the temptation to remove an
import which is used effectively.
vstinner added a commit to vstinner/cpython that referenced this issue Jun 12, 2024
@vstinner
pythongh-120417: Add #noqa to used imports in the stdlib
8347c30 
Tools such as ruff can ignore "imported but unused" warnings if a
line ends with "# noqa". It avoids the temptation to remove an import
which is used effectively.
@bedevere-app bedevere-app bot mentioned this issue Jun 12, 2024
Merged
vstinner added a commit that referenced this issue Jun 12, 2024
@vstinner
gh-120417: Remove unused imports in the stdlib (#120420)
4c6d4f5
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 12, 2024
@vstinner @miss-islington
pythongh-120417: Remove unused imports in the stdlib (pythonGH-120420)
70c31ec 
(cherry picked from commit 4c6d4f5)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app bedevere-app bot mentioned this issue Jun 12, 2024
Merged
vstinner added a commit that referenced this issue Jun 12, 2024
@miss-islington @vstinner
[3.13] gh-120417: Remove unused imports in the stdlib (GH-120420) (#1…
5172462 
…20429)

gh-120417: Remove unused imports in the stdlib (GH-120420)
(cherry picked from commit 4c6d4f5)

Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this issue Jun 13, 2024
@vstinner
gh-120417: Add #noqa to used imports in the stdlib (#120421)
6ae254a 
Tools such as ruff can ignore "imported but unused" warnings if a
line ends with "# noqa: F401". It avoids the temptation to remove
an import which is used effectively.
vstinner added a commit to vstinner/cpython that referenced this issue Jun 13, 2024
@vstinner
pythongh-120417: Add more #noqa to used imports in the stdlib
fc384b1 
Tools such as ruff can ignore "imported but unused" warnings if a
line ends with "# noqa: F401". It avoids the temptation to remove
an import which is used effectively.
@bedevere-app bedevere-app bot mentioned this issue Jun 13, 2024
Closed
vstinner added a commit to vstinner/cpython that referenced this issue Jun 13, 2024
@vstinner
pythongh-120417: Fix "imported but unused" linter warnings
56cbf55 
Add __all__ to the following modules: collections.abc,
importlib.machinery, importlib.util and xml.sax.

Add also "# noqa: F401" in subprocess and xml.sax on two lines.
@bedevere-app bedevere-app bot mentioned this issue Jun 13, 2024
Merged
vstinner added a commit that referenced this issue Jun 14, 2024
@vstinner
gh-120417: Fix "imported but unused" linter warnings (#120461)
05df063 
Add __all__ to the following modules:
importlib.machinery, importlib.util and xml.sax.

Add also "# noqa: F401" in collections.abc,
subprocess and xml.sax.

* Sort __all__; remove collections.abc.__all__; remove private names

* Add tests
terryjreedy added a commit to terryjreedy/cpython that referenced this issue Jun 16, 2024
@terryjreedy
[3.12] pythongh-120417: Remove unused import in idlelib (pythonGH-120420
459cd6b 
)

(cherry picked from commit 4c6d4f5)

Co-authored-by: Victor Stinner vstinner@python.org
@bedevere-app bedevere-app bot mentioned this issue Jun 16, 2024
Merged
terryjreedy added a commit that referenced this issue Jun 16, 2024
@terryjreedy
[3.12] gh-120417: Remove unused import in idlelib (GH-120420) (#120574)
51af315 
(cherry picked from commit 4c6d4f5)

Co-authored-by: Victor Stinner vstinner@python.org
@terryjreedy
Copy link
Member

Victor, can this be closed?

@vstinner
Copy link
Member Author

Please keep it open. I would like to visit some options for ssl and ctypes. And check imports in tests.

vstinner added a commit to vstinner/cpython that referenced this issue Jun 17, 2024
@vstinner
pythongh-120417: Remove unused imports in cases_generator
109cd63
@bedevere-app bedevere-app bot mentioned this issue Jun 17, 2024
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Jun 17, 2024
@vstinner
pythongh-120417: Remove unused imports in Tools
c768718
@bedevere-app bedevere-app bot mentioned this issue Jun 17, 2024
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Jun 17, 2024
@vstinner
pythongh-120417: Add #noqa to load_tests() in tests
59c1e46
@bedevere-app bedevere-app bot mentioned this issue Jun 17, 2024
Closed
vstinner added a commit to vstinner/cpython that referenced this issue Jun 17, 2024
@vstinner
pythongh-120417: Add #noqa: F401 to tests
dcc498e 
Ignore linter "imported but unused" warnings in tests when the linter
doesn't understand why the import is important.
mrahtz pushed a commit to mrahtz/cpython that referenced this issue Jun 30, 2024
@vstinner @mrahtz
pythongh-120417: Remove unused imports in cases_generator (python#120622
83f7254 
)
mrahtz pushed a commit to mrahtz/cpython that referenced this issue Jun 30, 2024
@vstinner @mrahtz
pythongh-120417: Move imports to doctests in test_doctest (python#120679
41765b6 
)
mrahtz pushed a commit to mrahtz/cpython that referenced this issue Jun 30, 2024
@vstinner @mrahtz
pythongh-120417: Use import_helper() in test_regrtest (python#120680)
0580e94
mrahtz pushed a commit to mrahtz/cpython that referenced this issue Jun 30, 2024
@vstinner @mrahtz
pythongh-120417: Add #noqa: F401 to tests (python#120627)
364df97 
Ignore linter "imported but unused" warnings in tests when the linter
doesn't understand how the import is used.
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@vstinner @noahbkim
pythongh-120417: Remove unused imports in the stdlib (python#120420)
d6202ee
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@vstinner @noahbkim
pythongh-120417: Add #noqa to used imports in the stdlib (python#120421)
173e176 
Tools such as ruff can ignore "imported but unused" warnings if a
line ends with "# noqa: F401". It avoids the temptation to remove
an import which is used effectively.
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@vstinner @noahbkim
pythongh-120417: Fix "imported but unused" linter warnings (python#12…
513232a 
…0461)

Add __all__ to the following modules:
importlib.machinery, importlib.util and xml.sax.

Add also "# noqa: F401" in collections.abc,
subprocess and xml.sax.

* Sort __all__; remove collections.abc.__all__; remove private names

* Add tests
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@vstinner @noahbkim
pythongh-120417: Remove unused imports in tests (part 4) (python#120632)
c842ec2
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@vstinner @noahbkim
pythongh-120417: Remove unused imports in Tools (python#120623)
c7040dd
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@vstinner @noahbkim
pythongh-120417: Remove unused imports in tests (part 3) (python#120631)
545cc7c
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@vstinner @noahbkim
pythongh-120417: Remove unused imports in tests (part 2) (python#120630)
aab8af8
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@vstinner @noahbkim
pythongh-120417: Remove unused imports in tests (part 1) (python#120629)
dac06d1
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@vstinner @noahbkim
pythongh-120417: Modify test_bdb to use the import (python#120628)
0a072fb 
Run test_module_for_bdb with a specific namespace.
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@vstinner @noahbkim
pythongh-120417: Remove unused imports in cases_generator (python#120622
1b1b7f6 
)
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@vstinner @noahbkim
pythongh-120417: Move imports to doctests in test_doctest (python#120679
24f8f9c 
)
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@vstinner @noahbkim
pythongh-120417: Use import_helper() in test_regrtest (python#120680)
cb2d8a1
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@vstinner @noahbkim
pythongh-120417: Add #noqa: F401 to tests (python#120627)
382e78f 
Ignore linter "imported but unused" warnings in tests when the linter
doesn't understand how the import is used.
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@vstinner @estyxx
pythongh-120417: Remove unused imports in the stdlib (python#120420)
6dff6fe
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@vstinner @estyxx
pythongh-120417: Add #noqa to used imports in the stdlib (python#120421)
cd91fb4 
Tools such as ruff can ignore "imported but unused" warnings if a
line ends with "# noqa: F401". It avoids the temptation to remove
an import which is used effectively.
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@vstinner @estyxx
pythongh-120417: Fix "imported but unused" linter warnings (python#12…
5800a9e 
…0461)

Add __all__ to the following modules:
importlib.machinery, importlib.util and xml.sax.

Add also "# noqa: F401" in collections.abc,
subprocess and xml.sax.

* Sort __all__; remove collections.abc.__all__; remove private names

* Add tests
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@vstinner @estyxx
pythongh-120417: Remove unused imports in tests (part 4) (python#120632)
9e04066
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@vstinner @estyxx
pythongh-120417: Remove unused imports in Tools (python#120623)
17febe6
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@vstinner @estyxx
pythongh-120417: Remove unused imports in tests (part 3) (python#120631)
15a194d
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@vstinner @estyxx
pythongh-120417: Remove unused imports in tests (part 2) (python#120630)
8ea0525
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@vstinner @estyxx
pythongh-120417: Remove unused imports in tests (part 1) (python#120629)
f20d131
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@vstinner @estyxx
pythongh-120417: Modify test_bdb to use the import (python#120628)
de3616c 
Run test_module_for_bdb with a specific namespace.
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@vstinner @estyxx
pythongh-120417: Remove unused imports in cases_generator (python#120622
4cf1312 
)
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@vstinner @estyxx
pythongh-120417: Move imports to doctests in test_doctest (python#120679
eebd4d4 
)
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@vstinner @estyxx
pythongh-120417: Use import_helper() in test_regrtest (python#120680)
042bf76
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@vstinner @estyxx
pythongh-120417: Add #noqa: F401 to tests (python#120627)
60df5cc 
Ignore linter "imported but unused" warnings in tests when the linter
doesn't understand how the import is used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vstinner @encukou @hugovk @terryjreedy