Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-120417: Move imports to doctests in test_doctest #120679

Merged
merged 1 commit into from
Jun 18, 2024
Merged

gh-120417: Move imports to doctests in test_doctest #120679

merged 1 commit into from
Jun 18, 2024

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jun 18, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Jun 18, 2024
@bedevere-app bedevere-app bot mentioned this pull request Jun 18, 2024
Closed
@vstinner
Copy link
Member Author

cc @serhiy-storchaka

@vstinner vstinner mentioned this pull request Jun 18, 2024
Merged
serhiy-storchaka
serhiy-storchaka approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But it is up to you what variant do you prefer.

@vstinner vstinner merged commit d2e4231 into python:main Jun 18, 2024
36 checks passed
@vstinner vstinner deleted the test_doctest branch June 18, 2024 13:54
@vstinner
Copy link
Member Author

But it is up to you what variant do you prefer.

This approach is more verbose than #noqa:F401, but IMO it's better to move imports where they are used.

picnixz pushed a commit to picnixz/cpython that referenced this pull request Jun 19, 2024
@vstinner @picnixz
pythongh-120417: Move imports to doctests in test_doctest (python#120679
aae5a27 
)
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@vstinner @mrahtz
pythongh-120417: Move imports to doctests in test_doctest (python#120679
41765b6 
)
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@vstinner @noahbkim
pythongh-120417: Move imports to doctests in test_doctest (python#120679
24f8f9c 
)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@vstinner @estyxx
pythongh-120417: Move imports to doctests in test_doctest (python#120679
eebd4d4 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @serhiy-storchaka