Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ntpath.normpath() for drive-relative paths #126780

Closed
nineteendo opened this issue Nov 13, 2024 · 0 comments
Closed

Fix ntpath.normpath() for drive-relative paths #126780

nineteendo opened this issue Nov 13, 2024 · 0 comments
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) OS-windows type-bug An unexpected behavior, bug, or error

Comments

@nineteendo
Copy link
Contributor

nineteendo commented Nov 13, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

from @eryksun (#117855 (comment)):

Note that the behavior for normalizing drive-relative paths is currently wrong in this case on Windows:

>>> nt._path_normpath('C:./spam')
'C:.\\spam'

That's the result that we want here when returning an explicit current directory for internal use, but that's not the expected behavior for normpath(). The fallback implementation that's used on POSIX gets it right:

>>> ntpath.normpath('C:./spam')
'C:spam'

CPython versions tested on:

CPython main branch

Operating systems tested on:

Windows

Linked PRs
@nineteendo nineteendo added the type-bug An unexpected behavior, bug, or error label Nov 13, 2024
@bedevere-app bedevere-app bot mentioned this issue Nov 13, 2024
Merged
@picnixz picnixz added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Nov 14, 2024
zooba pushed a commit that referenced this issue Nov 21, 2024
@nineteendo
gh-126780: Fix ntpath.normpath() for drive-relative paths (GH-126801)
60ec854
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 21, 2024
@nineteendo @miss-islington
pythongh-126780: Fix ntpath.normpath() for drive-relative paths (py…
f7671da 
…thonGH-126801)

(cherry picked from commit 60ec854)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
@bedevere-app bedevere-app bot mentioned this issue Nov 21, 2024
Merged
@zooba zooba closed this as completed Nov 21, 2024
zooba pushed a commit that referenced this issue Nov 21, 2024
@miss-islington @nineteendo
gh-126780: Fix ntpath.normpath() for drive-relative paths (GH-126801)
48eb5c9 
(cherry picked from commit 60ec854)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) OS-windows type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zooba @picnixz @erlend-aasland @nineteendo