Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-126780: Fix ntpath.normpath() for drive-relative paths #126801

Merged
merged 4 commits into from
Nov 21, 2024
Merged

gh-126780: Fix ntpath.normpath() for drive-relative paths #126801

merged 4 commits into from
Nov 21, 2024

Conversation

nineteendo
Copy link
Contributor

@nineteendo nineteendo commented Nov 13, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Nov 13, 2024
Closed
@nineteendo nineteendo marked this pull request as ready for review November 13, 2024 19:15
@nineteendo
Copy link
Contributor Author

cc @zooba, @barneygale

barneygale
barneygale approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@barneygale barneygale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test cases LGTM but I haven't reviewed the C code. Thanks

@zooba zooba merged commit 60ec854 into python:main Nov 21, 2024
43 checks passed
@zooba zooba added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Nov 21, 2024
@miss-islington-app
Copy link

Thanks @nineteendo for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

Thanks @nineteendo for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @nineteendo and @zooba, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 60ec854bc297e04718fe13db3605d0465bf8badb 3.12

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 21, 2024
@nineteendo @miss-islington
pythongh-126780: Fix ntpath.normpath() for drive-relative paths (py…
f7671da 
…thonGH-126801)

(cherry picked from commit 60ec854)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
@zooba
Copy link
Member

zooba commented Nov 21, 2024

Not sure if we need to go back to 3.12, but letting the bot decide... guess not!

@bedevere-app
Copy link

bedevere-app bot commented Nov 21, 2024

GH-127103 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 21, 2024
@zooba zooba removed the needs backport to 3.12 bug and security fixes label Nov 21, 2024
@nineteendo nineteendo deleted the fix-ntpath.normpath branch November 21, 2024 14:46
@nineteendo
Copy link
Contributor Author

Thanks.

zooba pushed a commit that referenced this pull request Nov 21, 2024
@miss-islington @nineteendo
gh-126780: Fix ntpath.normpath() for drive-relative paths (GH-126801)
48eb5c9 
(cherry picked from commit 60ec854)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruidazeng ruidazeng ruidazeng approved these changes

@barneygale barneygale barneygale approved these changes

@zooba zooba Awaiting requested review from zooba

@eryksun eryksun Awaiting requested review from eryksun

Assignees

@zooba zooba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nineteendo @zooba @barneygale @ruidazeng