-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression in the AC generated code #91583
Comments
Did you benchmark the difference? |
No, but |
+1
In sqlite3, for the sqlite3.Connection class, I store a pointer to the module state in the class context. A module state lookup in any of the connection methods is simply a class context member lookup. We could do a similar optimisation here. |
Argument Clinic now generates the same efficient code as before adding the defining_class parameter.
|
…_class (pythonGH-91739) Argument Clinic now generates the same efficient code as before adding the defining_class parameter.. (cherry picked from commit a055dac) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
…class (pythonGH-91739) Argument Clinic now generates the same efficient code as before adding the defining_class parameter.. (cherry picked from commit a055dac) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
…class (pythonGH-91739) (pythonGH-92080) Argument Clinic now generates the same efficient code as before adding the defining_class parameter. (cherry picked from commit a055dac)
Argument Clinic now generates less efficient code using
_PyArg_ParseStackAndKeywords
instead of_PyArg_UnpackKeywords
. It is a regression introduced after establishing module state. For example see #23393. It may be a cause of #91404.@erlend-aasland
The text was updated successfully, but these errors were encountered: