Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-91583: AC: Fix regression for functions with defining_class #91739

Merged
merged 5 commits into from
Apr 30, 2022
Merged

gh-91583: AC: Fix regression for functions with defining_class #91739

merged 5 commits into from
Apr 30, 2022

Conversation

serhiy-storchaka
Copy link
Member

Argument Clinic now generates the same efficient code as before
adding the defining_class parameter.

Closes #91583.

@serhiy-storchaka
pythongh-91583: AC: Fix regression for functions with defining_class
8f42028 
Argument Clinic now generates the same efficient code as before
adding the defining_class parameter.
@serhiy-storchaka serhiy-storchaka added performance Performance or resource usage needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Apr 20, 2022
@serhiy-storchaka serhiy-storchaka merged commit a055dac into python:main Apr 30, 2022
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a055dac0b45031878a8196a8735522de018491e3 3.10

@miss-islington
Copy link
Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker a055dac0b45031878a8196a8735522de018491e3 3.9

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Apr 30, 2022
@serhiy-storchaka
[3.10] pythongh-91583: AC: Fix regression for functions with defining…
fb8060b 
…_class (pythonGH-91739)

Argument Clinic now generates the same efficient code as before
adding the defining_class parameter..
(cherry picked from commit a055dac)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Apr 30, 2022
@serhiy-storchaka
[3.9] pythongh-91583: AC: Fix regression for functions with defining_…
01ca7b2 
…class (pythonGH-91739)

Argument Clinic now generates the same efficient code as before
adding the defining_class parameter..
(cherry picked from commit a055dac)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka mentioned this pull request Apr 30, 2022
Merged
@bedevere-bot
Copy link

GH-92079 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Apr 30, 2022
@serhiy-storchaka serhiy-storchaka mentioned this pull request Apr 30, 2022
Merged
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Apr 30, 2022
@bedevere-bot
Copy link

GH-92080 is a backport of this pull request to the 3.9 branch.

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Apr 30, 2022 •
edited
Loading

I started to review this PR, but I never got around to finish the review. I did take a good and long look1 at the changes; they make sense, and I did not find any issues. So, approved post merge :)

Thanks for doing this, Serhiy!

Footnotes

  1. it took me several days, as I was not familiar with how clinic.py actually worked ↩

@serhiy-storchaka serhiy-storchaka deleted the clinic-defining_class branch April 30, 2022 13:57
@serhiy-storchaka
Copy link
Member Author

Well, I don't think anyone has a complete picture in their head right now. At least not for a long time.

serhiy-storchaka added a commit that referenced this pull request May 3, 2022
@serhiy-storchaka
[3.10] gh-91583: AC: Fix regression for functions with defining_class (…
62ddbbc 
…GH-91739) (GH-92079)

Argument Clinic now generates the same efficient code as before
adding the defining_class parameter.
(cherry picked from commit a055dac)
serhiy-storchaka added a commit that referenced this pull request May 3, 2022
@serhiy-storchaka
[3.9] gh-91583: AC: Fix regression for functions with defining_class (G…
1b1c79c 
…H-91739) (GH-92080)

Argument Clinic now generates the same efficient code as before
adding the defining_class parameter.
(cherry picked from commit a055dac)
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@serhiy-storchaka @hello-adam
[3.9] pythongh-91583: AC: Fix regression for functions with defining_…
57d8a15 
…class (pythonGH-91739) (pythonGH-92080)

Argument Clinic now generates the same efficient code as before
adding the defining_class parameter.
(cherry picked from commit a055dac)
@serhiy-storchaka serhiy-storchaka removed their assignment Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

@tiran tiran Awaiting requested review from tiran tiran is a code owner

Assignees
No one assigned
Labels
performance Performance or resource usage topic-argument-clinic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression in the AC generated code
5 participants
@serhiy-storchaka @miss-islington @bedevere-bot @erlend-aasland @AlexWaygood