The docstring for os.mkdir should mention the effect of umask
#96288
Labels
docs
Documentation in the Doc dir
Comments
JelleZijlstra
pushed a commit
that referenced
this issue
Oct 7, 2022
JelleZijlstra
pushed a commit
to JelleZijlstra/cpython
that referenced
this issue
Oct 7, 2022
…honGH-96271). (cherry picked from commit 1523c9e) Co-authored-by: Hagai Helman Tov <hagai.helman@gmail.com>
This was referenced Oct 7, 2022
JelleZijlstra
pushed a commit
to JelleZijlstra/cpython
that referenced
this issue
Oct 7, 2022
…honGH-96271). (cherry picked from commit 1523c9e) Co-authored-by: Hagai Helman Tov <hagai.helman@gmail.com>
carljm
added a commit
to carljm/cpython
that referenced
this issue
Oct 8, 2022
* main: (38 commits) pythongh-92886: make test_ast pass with -O (assertions off) (pythonGH-98058) pythongh-92886: make test_coroutines pass with -O (assertions off) (pythonGH-98060) pythongh-57179: Add note on symlinks for os.walk (python#94799) pythongh-94808: Fix regex on exotic platforms (python#98036) pythongh-90085: Remove vestigial -t and -c timeit options (python#94941) pythonGH-83901: Improve Signature.bind error message for missing keyword-only params (python#95347) pythongh-61105: Add default param, note on using cookiejar subclass (python#95427) pythongh-96288: Add a sentence to `os.mkdir`'s docstring. (python#96271) pythongh-96073: fix backticks in NEWS entry (pythonGH-98056) pythongh-92886: [clinic.py] raise exception on invalid input instead of assertion (pythonGH-98051) pythongh-97997: Add col_offset field to tokenizer and use that for AST nodes (python#98000) pythonGH-88968: Reject socket that is already used as a transport (python#98010) pythongh-96346: Use double caching for re._compile() (python#96347) pythongh-91708: Revert params note in urllib.parse.urlparse table (python#96699) pythongh-96265: Fix some formatting in faq/design.rst (python#96924) pythongh-73196: Add namespace/scope clarification for inheritance section (python#92840) pythongh-97646: Change `.js` and `.mjs` files mimetype to conform to RFC 9239 (python#97934) pythongh-97923: Always run Ubuntu SSL tests with others in CI (python#97940) pythongh-97956: Mention `generate_global_objects.py` in `AC How-To` (python#97957) pythongh-96959: Update HTTP links which are redirected to HTTPS (python#98039) ...
mpage
pushed a commit
to mpage/cpython
that referenced
this issue
Oct 11, 2022
|
Thanks, looks like this has been completed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Documentation
In
os.mkdir, when the argumentmodeis used, the current umask value is first masked out of it. This behavior is mentioned in the library's documentation, but not in the docstring.This behavior may be unexpected for some (for example, this is not the behavior of GNU's
mkdircommand - when a mode is explicitly given to it, it overrides the umask). When one is unaware of this behavior, it can lead to bugs that are difficult to notice or trace. For these two reasons, I suggest it will be mentioned in the docstring.My edit suggestion is given in #96271.
The text was updated successfully, but these errors were encountered: