Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-92886: make test_coroutines pass with -O (assertions off) #98060

Merged
merged 1 commit into from
Oct 7, 2022
Merged

gh-92886: make test_coroutines pass with -O (assertions off) #98060

merged 1 commit into from
Oct 7, 2022

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Oct 7, 2022 •
edited by miss-islington
Loading

Automerge-Triggered-By: GH:iritkatriel

@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Oct 7, 2022
@iritkatriel iritkatriel requested a review from asvetlov October 7, 2022 20:51
@iritkatriel iritkatriel added skip news 3.12 bugs and security fixes labels Oct 7, 2022
@miss-islington
Copy link
Contributor

Status check is done, and it's a success ✅.

@miss-islington miss-islington merged commit 45f2147 into python:main Oct 7, 2022
@miss-islington
Copy link
Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-98073 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 7, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 7, 2022
@iritkatriel @miss-islington
pythongh-92886: make test_coroutines pass with -O (assertions off) (p…
947ea7f 
…ythonGH-98060)

Automerge-Triggered-By: GH:iritkatriel
(cherry picked from commit 45f2147)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 7, 2022
@bedevere-bot
Copy link

GH-98074 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 7, 2022
@iritkatriel @miss-islington
pythongh-92886: make test_coroutines pass with -O (assertions off) (p…
88bf237 
…ythonGH-98060)

Automerge-Triggered-By: GH:iritkatriel
(cherry picked from commit 45f2147)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Oct 8, 2022
@miss-islington @iritkatriel
gh-92886: make test_coroutines pass with -O (assertions off) (GH-98060)
8d40fbe 
Automerge-Triggered-By: GH:iritkatriel
(cherry picked from commit 45f2147)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Oct 8, 2022
@miss-islington @iritkatriel
gh-92886: make test_coroutines pass with -O (assertions off) (GH-98060)
72a23d8 
Automerge-Triggered-By: GH:iritkatriel
(cherry picked from commit 45f2147)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@zware
Copy link
Member

zware commented Oct 8, 2022

Judging from the comment in the test, I wonder if this change defeated the purpose of the test. I haven't looked into the history, but it might have been better to skip the test when run with -O.

@iritkatriel
Copy link
Member Author

I assumed that comment was talking about the relevant async opcodes rather than the ‘assert’ opcodes.

Maybe @1st1 can confirm?

carljm added a commit to carljm/cpython that referenced this pull request Oct 8, 2022
@carljm
Merge branch 'main' into typewatch
27a4980 
* main: (38 commits)
  pythongh-92886: make test_ast pass with -O (assertions off) (pythonGH-98058)
  pythongh-92886: make test_coroutines pass with -O (assertions off) (pythonGH-98060)
  pythongh-57179: Add note on symlinks for os.walk (python#94799)
  pythongh-94808: Fix regex on exotic platforms (python#98036)
  pythongh-90085: Remove vestigial -t and -c timeit options (python#94941)
  pythonGH-83901: Improve Signature.bind error message for missing keyword-only params (python#95347)
  pythongh-61105: Add default param, note on using cookiejar subclass (python#95427)
  pythongh-96288: Add a sentence to `os.mkdir`'s docstring. (python#96271)
  pythongh-96073: fix backticks in NEWS entry (pythonGH-98056)
  pythongh-92886: [clinic.py] raise exception on invalid input instead of assertion (pythonGH-98051)
  pythongh-97997: Add col_offset field to tokenizer and use that for AST nodes (python#98000)
  pythonGH-88968: Reject socket that is already used as a transport (python#98010)
  pythongh-96346: Use double caching for re._compile() (python#96347)
  pythongh-91708: Revert params note in urllib.parse.urlparse table (python#96699)
  pythongh-96265: Fix some formatting in faq/design.rst (python#96924)
  pythongh-73196: Add namespace/scope clarification for inheritance section (python#92840)
  pythongh-97646: Change `.js` and `.mjs` files mimetype to conform to RFC 9239 (python#97934)
  pythongh-97923: Always run Ubuntu SSL tests with others in CI (python#97940)
  pythongh-97956: Mention `generate_global_objects.py` in `AC How-To` (python#97957)
  pythongh-96959: Update HTTP links which are redirected to HTTPS (python#98039)
  ...
carljm added a commit to carljm/cpython that referenced this pull request Oct 9, 2022
@carljm
Merge branch 'main' into urllibnonet
132c32e 
* main: (5519 commits)
  Minor edits to the Descriptor HowTo Guide (pythonGH-24901)
  Fix link to Lifecycle of a Pull Request in CONTRIBUTING (python#98102)
  pythonGH-94597: deprecate `SafeChildWatcher`, `FastChildWatcher` and `MultiLoopChildWatcher` child watchers  (python#98089)
  Auto-cancel old builds when new commit pushed to branch (python#98009)
  pythongh-95011: Migrate syslog module to Argument Clinic (pythonGH-95012)
  pythongh-68686: Retire eptag ptag scripts (python#98064)
  pythongh-97922: Run the GC only on eval breaker (python#97920)
  GitHub Workflows security hardening (python#96492)
  Add `@ezio-melotti` as codeowner for `.github/`. (python#98079)
  pythongh-97913 Docs: Add walrus operator to the index (python#97921)
  [doc] Fix broken links to C extensions accelerating stdlib modules (python#96914)
  pythongh-97822: Fix http.server documentation reference to test() function (python#98027)
  pythongh-91052: Add PyDict_Unwatch for unwatching a dictionary (python#98055)
  pythonGH-98023: Change default child watcher to PidfdChildWatcher on supported systems (python#98024)
  pythonGH-94182: Run the PidfdChildWatcher on the running loop (python#94184)
  pythongh-92886: make test_ast pass with -O (assertions off) (pythonGH-98058)
  pythongh-92886: make test_coroutines pass with -O (assertions off) (pythonGH-98060)
  pythongh-57179: Add note on symlinks for os.walk (python#94799)
  pythongh-94808: Fix regex on exotic platforms (python#98036)
  pythongh-90085: Remove vestigial -t and -c timeit options (python#94941)
  ...
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
@iritkatriel @mpage
pythongh-92886: make test_coroutines pass with -O (assertions off) (p…
dcbae74 
…ythonGH-98060)

Automerge-Triggered-By: GH:iritkatriel
@iritkatriel iritkatriel deleted the test_coroutine branch October 18, 2022 14:23
@JelleZijlstra JelleZijlstra mentioned this pull request Oct 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov

Assignees
No one assigned
Labels
3.12 bugs and security fixes skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iritkatriel @miss-islington @bedevere-bot @zware @JelleZijlstra