Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-87092: Make jump target label equal to the offset of the target in the instructions sequence #102093

Merged
merged 6 commits into from
Feb 28, 2023

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Feb 21, 2023

In the instruction stream exposed by the compiler to Python for testing, the labels are no longer included as explicit entries. Instead, the offset of the target instruction in the stream is used.

This is a step towards the codegen producing an instruction stream instead of basic blocks.

Python/compile.c Outdated Show resolved Hide resolved
@iritkatriel
Copy link
Member Author

This windows test failure is unrelated.

Note that this PR is only changing test code.

Python/compile.c Outdated Show resolved Hide resolved
@iritkatriel iritkatriel added the tests Tests in the Lib/test dir label Feb 27, 2023
@iritkatriel iritkatriel changed the title gh-87092: Jump target label is now the offset of the target in the instructions sequence gh-87092: Make jump target label equal to the offset of the target in the instructions sequence Feb 27, 2023
@iritkatriel
Copy link
Member Author

@markshannon Did you say you've had look at this PR?

Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is only for testing, I'll trust you that is a worthwhile change.

It looks correct.

@iritkatriel iritkatriel merged commit 9f799ab into python:main Feb 28, 2023
carljm added a commit to carljm/cpython that referenced this pull request Feb 28, 2023
* main: (67 commits)
  pythongh-99108: Add missing md5/sha1 defines to Modules/Setup (python#102308)
  pythongh-100227: Move _str_replace_inf to PyInterpreterState (pythongh-102333)
  pythongh-100227: Move the dtoa State to PyInterpreterState (pythongh-102331)
  pythonGH-102305: Expand some macros in generated_cases.c.h (python#102309)
  Migrate to new PSF mailgun account (python#102284)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Python/) (python#102193)
  pythonGH-90744: Fix erroneous doc links in the sys module (python#101319)
  pythongh-87092: Make jump target label equal to the offset of the target in the instructions sequence (python#102093)
  pythongh-101101: Unstable C API tier (PEP 689) (pythonGH-101102)
  IDLE: Simplify DynOptionsMenu __init__code (python#101371)
  pythongh-101561: Add typing.override decorator (python#101564)
  pythongh-101825: Clarify that as_integer_ratio() output is always normalized (python#101843)
  pythongh-101773: Optimize creation of Fractions in private methods (python#101780)
  pythongh-102251: Updates to test_imp Toward Fixing Some Refleaks (pythongh-102254)
  pythongh-102296 Document that inspect.Parameter kinds support ordering (pythonGH-102297)
  pythongh-102250: Fix double-decref in COMPARE_AND_BRANCH error case (pythonGH-102287)
  pythongh-101100: Fix sphinx warnings in `types` module (python#102274)
  pythongh-91038: Change default argument value to `False` instead of `0` (python#31621)
  pythongh-101765: unicodeobject: use Py_XDECREF correctly (python#102283)
  [doc] Improve grammar/fix missing word (pythonGH-102060)
  ...
@iritkatriel iritkatriel deleted the label-is-index branch April 3, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants