-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Python/) #102193
Conversation
Skipping news because these are internal-only changes, and the fact of PyErr_Fetch/Restore being obsolete is already in the news. |
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 9abebe0 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
There's a refcount issue somewhere. Checking. |
I must say this is a great improvement in readability. The new API is indeed a better API. Thanks! |
9abebe0
to
b5150cc
Compare
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 603922d 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit df86e20 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit f29ca0b 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
There's only one failure now, in an AMD64 RHEL7 builedbot which has been flaky for a couple of months. I'll call it a pass. |
It passes now, so this PR should be fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor edit needed, otherwise LGTM.
When you're done making the requested changes, leave the comment: |
* main: (67 commits) pythongh-99108: Add missing md5/sha1 defines to Modules/Setup (python#102308) pythongh-100227: Move _str_replace_inf to PyInterpreterState (pythongh-102333) pythongh-100227: Move the dtoa State to PyInterpreterState (pythongh-102331) pythonGH-102305: Expand some macros in generated_cases.c.h (python#102309) Migrate to new PSF mailgun account (python#102284) pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Python/) (python#102193) pythonGH-90744: Fix erroneous doc links in the sys module (python#101319) pythongh-87092: Make jump target label equal to the offset of the target in the instructions sequence (python#102093) pythongh-101101: Unstable C API tier (PEP 689) (pythonGH-101102) IDLE: Simplify DynOptionsMenu __init__code (python#101371) pythongh-101561: Add typing.override decorator (python#101564) pythongh-101825: Clarify that as_integer_ratio() output is always normalized (python#101843) pythongh-101773: Optimize creation of Fractions in private methods (python#101780) pythongh-102251: Updates to test_imp Toward Fixing Some Refleaks (pythongh-102254) pythongh-102296 Document that inspect.Parameter kinds support ordering (pythonGH-102297) pythongh-102250: Fix double-decref in COMPARE_AND_BRANCH error case (pythonGH-102287) pythongh-101100: Fix sphinx warnings in `types` module (python#102274) pythongh-91038: Change default argument value to `False` instead of `0` (python#31621) pythongh-101765: unicodeobject: use Py_XDECREF correctly (python#102283) [doc] Improve grammar/fix missing word (pythonGH-102060) ...
This PR does most of Python/.