Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-102515: Remove unused imports in the Lib/ directory #102516

Merged
merged 4 commits into from
Mar 8, 2023
Merged

gh-102515: Remove unused imports in the Lib/ directory #102516

merged 4 commits into from
Mar 8, 2023

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Mar 7, 2023 •
edited
Loading

Identified using the pycln tool; manually reviewed by me.

@bedevere-bot bedevere-bot mentioned this pull request Mar 7, 2023
Closed
@AlexWaygood AlexWaygood added skip news stdlib Python modules in the Lib dir labels Mar 7, 2023
gvanrossum
gvanrossum reviewed Mar 7, 2023
View reviewed changes
Lib/concurrent/futures/process.py Show resolved Hide resolved
Lib/multiprocessing/queues.py Outdated Show resolved Hide resolved
Lib/test/test_asyncio/test_ssl.py Show resolved Hide resolved
Lib/test/test_peg_generator/test_c_parser.py Show resolved Hide resolved
@hugovk
Copy link
Member

hugovk commented Mar 7, 2023

Maybe worth commenting some of the less-obvious, required imports for next time?

@terryjreedy
Copy link
Member

Of the 34 files with 'extra' imports, 28 are in test. If the tests pass, we may assume that the deletions are really unused. I am checking the deletions in regular code and already found an error.

@terryjreedy
Copy link
Member

Guido refuted my comment about not checking tests, and found the issue with multliprocessing.connection. I consider that to be a bug in pycln.

@terryjreedy terryjreedy closed this Mar 7, 2023
@terryjreedy terryjreedy reopened this Mar 7, 2023
@AlexWaygood
Copy link
Member Author

I consider that to be a bug in pycln.

It's an imperfect tool, and the stdlib is possibly the worst kind of code to judge it on. I've had good experiences with using the tool on other projects, but if you simply run pycln Lib --all in the CPython repo, it removes 290 imports from 150 files. Most of these are false positives.

@rhettinger rhettinger removed their request for review March 8, 2023 02:49
@pablogsal pablogsal merged commit 401d7a7 into python:main Mar 8, 2023
@AlexWaygood AlexWaygood deleted the unused-imports branch March 8, 2023 11:47
@AlexWaygood
Copy link
Member Author

AlexWaygood commented Mar 8, 2023 •
edited
Loading

Thanks @gvanrossum, @terryjreedy and @kumaraditya303 for the careful reviews! Much appreciated.

carljm added a commit to carljm/cpython that referenced this pull request Mar 8, 2023
@carljm
Merge branch 'main' into inlinecomp2
06db319 
* main:
  pythongh-102304: Consolidate Direct Usage of _Py_RefTotal (pythongh-102514)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Objects/) (python#102218)
  pythongh-102507 Remove invisible pagebreak characters (python#102531)
  pythongh-102515: Remove unused imports in the `Lib/` directory (python#102516)
  Remove or update bitbucket links (pythonGH-101963)
  pythongh-101100: Fix sphinx warnings in `zipapp` and `zipfile` modules (python#102526)
  pythonGH-102397: Fix segfault from race condition in signal handling (python#102399)
  Fix style in argparse.rst (python#101733)
  Post 3.12.0a6
  fix typo in async generator code field name `ag_code` (python#102448)
  Python 3.12.0a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@FFY00 FFY00 FFY00 approved these changes

@gvanrossum gvanrossum gvanrossum approved these changes

@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner

@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@vsajip vsajip Awaiting requested review from vsajip

@tiran tiran Awaiting requested review from tiran tiran is a code owner

@iritkatriel iritkatriel Awaiting requested review from iritkatriel

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
skip news stdlib Python modules in the Lib dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unused imports in the Lib/ directory
8 participants
@AlexWaygood @hugovk @terryjreedy @gvanrossum @FFY00 @kumaraditya303 @pablogsal @bedevere-bot