Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-101100: Fix sphinx warnings in zipapp and zipfile modules #102526

Merged
merged 1 commit into from
Mar 8, 2023
Merged

gh-101100: Fix sphinx warnings in zipapp and zipfile modules #102526

merged 1 commit into from
Mar 8, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Mar 8, 2023 •
edited
Loading

I've decided to unite these simple fixes into a single PR.

Warnings:

./cpython/Doc/library/zipapp.rst:218: WARNING: py:class reference target not found: BytesIO
./cpython/Doc/library/zipfile.rst:287: WARNING: py:meth reference target not found: __iter__

Some details:

  1. Fixed missing link to https://docs.python.org/3/library/io.html#io.BytesIO
  2. Fixed missing link to https://docs.python.org/3/library/stdtypes.html#container.__iter__

@sobolevn sobolevn requested a review from hugovk March 8, 2023 07:50
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels Mar 8, 2023
@bedevere-bot bedevere-bot mentioned this pull request Mar 8, 2023
Open
@AlexWaygood AlexWaygood merged commit 1f557f9 into python:main Mar 8, 2023
@AlexWaygood AlexWaygood added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Mar 8, 2023
@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 8, 2023
@sobolevn @miss-islington
pythongh-101100: Fix sphinx warnings in zipapp and zipfile modules (
97afd37 
pythonGH-102526)

(cherry picked from commit 1f557f9)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot
Copy link

GH-102529 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 8, 2023
@sobolevn @miss-islington
pythongh-101100: Fix sphinx warnings in zipapp and zipfile modules (
3046f48 
pythonGH-102526)

(cherry picked from commit 1f557f9)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Mar 8, 2023
@bedevere-bot
Copy link

GH-102530 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Mar 8, 2023
miss-islington added a commit that referenced this pull request Mar 8, 2023
@miss-islington @sobolevn
gh-101100: Fix sphinx warnings in zipapp and zipfile modules (GH-…
ffb41ea 
…102526)

(cherry picked from commit 1f557f9)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington added a commit that referenced this pull request Mar 8, 2023
@miss-islington @sobolevn
gh-101100: Fix sphinx warnings in zipapp and zipfile modules (GH-…
7276ee0 
…102526)

(cherry picked from commit 1f557f9)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
carljm added a commit to carljm/cpython that referenced this pull request Mar 8, 2023
@carljm
Merge branch 'main' into inlinecomp2
06db319 
* main:
  pythongh-102304: Consolidate Direct Usage of _Py_RefTotal (pythongh-102514)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Objects/) (python#102218)
  pythongh-102507 Remove invisible pagebreak characters (python#102531)
  pythongh-102515: Remove unused imports in the `Lib/` directory (python#102516)
  Remove or update bitbucket links (pythonGH-101963)
  pythongh-101100: Fix sphinx warnings in `zipapp` and `zipfile` modules (python#102526)
  pythonGH-102397: Fix segfault from race condition in signal handling (python#102399)
  Fix style in argparse.rst (python#101733)
  Post 3.12.0a6
  fix typo in async generator code field name `ag_code` (python#102448)
  Python 3.12.0a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@hugovk hugovk Awaiting requested review from hugovk

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sobolevn @miss-islington @bedevere-bot @AlexWaygood