Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104876: Remove deprecated turtle.RawTurtle.settiltangle #104877

Merged
merged 5 commits into from
May 26, 2023
Merged

gh-104876: Remove deprecated turtle.RawTurtle.settiltangle #104877

merged 5 commits into from
May 26, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented May 24, 2023 •
edited by bedevere-bot
Loading

Closes #104876.

Remove the turtle.RawTurtle.settiltangle method, deprecated in docs since Python 3.1 and with a warning since Python 3.11.

📚 Documentation preview 📚: https://cpython-previews--104877.org.readthedocs.build/

@hugovk hugovk added 3.13 bugs and security fixes and removed awaiting core review labels May 24, 2023
@hugovk hugovk changed the title Remove deprecated turtle.RawTurtle.settiltangle gh-104876: Remove deprecated turtle.RawTurtle.settiltangle May 24, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 24, 2023
Closed
@hugovk hugovk added the stdlib Python modules in the Lib dir label May 25, 2023
@hugovk hugovk mentioned this pull request May 25, 2023
Merged
vstinner
vstinner approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I left minor remarks. Also, I never used the turtle module, so I don't know how to test this change. Lib/test/test_turtle.py checks that there is no regression, no?

Lib/turtle.py Outdated Show resolved Hide resolved
Doc/whatsnew/3.13.rst Outdated Show resolved Hide resolved
hugovk and others added 3 commits May 25, 2023 19:16
@hugovk @vstinner
Improve wording
dd17c3e 
Co-authored-by: Victor Stinner <vstinner@python.org>
@hugovk
Remove outdated comment
df25c04
@hugovk
Improve wording
e0fdf63
vstinner
vstinner approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hugovk hugovk merged commit 10c4583 into python:main May 26, 2023
@hugovk hugovk deleted the rm-turtle-settiltangle branch May 26, 2023 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
3.13 bugs and security fixes stdlib Python modules in the Lib dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deprecated turtle.RawTurtle.settiltangle method
3 participants
@hugovk @vstinner @bedevere-bot