Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-104876: Remove deprecated turtle.RawTurtle.settiltangle #104877

Merged
merged 5 commits into from
May 26, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 1 addition & 25 deletions Doc/library/turtle.rst
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,6 @@ Turtle state
| :func:`resizemode`
| :func:`shapesize` | :func:`turtlesize`
| :func:`shearfactor`
| :func:`settiltangle`
| :func:`tiltangle`
| :func:`tilt`
| :func:`shapetransform`
Expand Down Expand Up @@ -1301,28 +1300,6 @@ Appearance
>>> turtle.fd(50)


.. function:: settiltangle(angle)

:param angle: a number

Rotate the turtleshape to point in the direction specified by *angle*,
regardless of its current tilt-angle. *Do not* change the turtle's heading
(direction of movement).

.. doctest::
:skipif: _tkinter is None or 'always; deprecated method'

>>> turtle.reset()
>>> turtle.shape("circle")
>>> turtle.shapesize(5,2)
>>> turtle.settiltangle(45)
>>> turtle.fd(50)
>>> turtle.settiltangle(-45)
>>> turtle.fd(50)

.. deprecated:: 3.1


.. function:: tiltangle(angle=None)

:param angle: a number (optional)
Expand Down Expand Up @@ -2529,8 +2506,7 @@ Changes since Python 3.0
:func:`get_shapepoly` have been added. Thus the full range of
regular linear transforms is now available for transforming turtle shapes.
:func:`tiltangle` has been enhanced in functionality: it now can
be used to get or set the tilt angle. :func:`settiltangle` has been
deprecated.
be used to get or set the tilt angle.

- The :class:`Screen` method :func:`onkeypress` has been added as a complement to
:func:`onkey`. As the latter binds actions to the key release event,
Expand Down
2 changes: 1 addition & 1 deletion Doc/whatsnew/3.11.rst
Original file line number Diff line number Diff line change
Expand Up @@ -1817,7 +1817,7 @@ Standard Library
They will be removed in Python 3.13.
(Contributed by Serhiy Storchaka and Miro Hrončok in :gh:`92728`.)

* :func:`turtle.settiltangle` has been deprecated since Python 3.1;
* :func:`!turtle.settiltangle` has been deprecated since Python 3.1;
it now emits a deprecation warning and will be removed in Python 3.13. Use
:func:`turtle.tiltangle` instead (it was earlier incorrectly marked
as deprecated, and its docstring is now corrected).
Expand Down
7 changes: 5 additions & 2 deletions Doc/whatsnew/3.13.rst
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,11 @@ Removed
* Remove support for using :class:`pathlib.Path` objects as context managers.
This functionality was deprecated and made a no-op in Python 3.9.

* Remove the :meth:`!turtle.RawTurtle.settiltangle` method,
deprecated in docs since Python 3.1
and with a warning since Python 3.11.
hugovk marked this conversation as resolved.
Show resolved Hide resolved
(Contributed by Hugo van Kemenade in :gh:`104876`.)

* Removed the following :mod:`unittest` functions, deprecated in Python 3.11:

* :func:`!unittest.findTestCases`
Expand All @@ -130,8 +135,6 @@ Removed
* :meth:`unittest.TestLoader.loadTestsFromTestCase`
* :meth:`unittest.TestLoader.getTestCaseNames`

(Contributed by Hugo van Kemenade in :gh:`104835`.)

* :pep:`594`: Remove the :mod:`!cgi`` and :mod:`!cgitb` modules,
deprecated in Python 3.11.

Expand Down
33 changes: 3 additions & 30 deletions Lib/turtle.py
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@
'isvisible', 'left', 'lt', 'onclick', 'ondrag', 'onrelease', 'pd',
'pen', 'pencolor', 'pendown', 'pensize', 'penup', 'pos', 'position',
'pu', 'radians', 'right', 'reset', 'resizemode', 'rt',
'seth', 'setheading', 'setpos', 'setposition', 'settiltangle',
'seth', 'setheading', 'setpos', 'setposition',
'setundobuffer', 'setx', 'sety', 'shape', 'shapesize', 'shapetransform', 'shearfactor', 'showturtle',
'speed', 'st', 'stamp', 'teleport', 'tilt', 'tiltangle', 'towards',
'turtlesize', 'undo', 'undobufferentries', 'up', 'width',
Expand Down Expand Up @@ -2896,33 +2896,6 @@ def shearfactor(self, shear=None):
return self._shearfactor
self.pen(resizemode="user", shearfactor=shear)

def settiltangle(self, angle):
"""Rotate the turtleshape to point in the specified direction

Argument: angle -- number

Rotate the turtleshape to point in the direction specified by angle,
regardless of its current tilt-angle. DO NOT change the turtle's
heading (direction of movement).

Deprecated since Python 3.1

Examples (for a Turtle instance named turtle):
>>> turtle.shape("circle")
>>> turtle.shapesize(5,2)
>>> turtle.settiltangle(45)
>>> turtle.stamp()
>>> turtle.fd(50)
>>> turtle.settiltangle(-45)
>>> turtle.stamp()
>>> turtle.fd(50)
"""
warnings._deprecated("turtle.RawTurtle.settiltangle()",
"{name!r} is deprecated since Python 3.1 and scheduled "
"for removal in Python {remove}. Use tiltangle() instead.",
remove=(3, 13))
self.tiltangle(angle)

def tiltangle(self, angle=None):
"""Set or return the current tilt-angle.

Expand All @@ -2935,8 +2908,8 @@ def tiltangle(self, angle=None):
between the orientation of the turtleshape and the heading of the
turtle (its direction of movement).

(Incorrectly marked as deprecated since Python 3.1, it is really
settiltangle that is deprecated.)
(Incorrectly marked as deprecated since Python 3.1, it was really
settiltangle that was deprecated (and removed in 3.13).)
hugovk marked this conversation as resolved.
Show resolved Hide resolved

Examples (for a Turtle instance named turtle):
>>> turtle.shape("circle")
Expand Down
2 changes: 1 addition & 1 deletion Misc/NEWS.d/3.11.0a3.rst
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,7 @@ Added missing kw_only parameter to dataclasses.make_dataclass().
.. nonce: aGyr1I
.. section: Library

The :meth:`turtle.RawTurtle.settiltangle` is deprecated since Python 3.1, it
The :meth:`!turtle.RawTurtle.settiltangle` is deprecated since Python 3.1, it
now emits a deprecation warning and will be removed in Python 3.13.

Use :meth:`turtle.RawTurtle.tiltangle` instead.
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Remove the :meth:`!turtle.RawTurtle.settiltangle` method, deprecated in docs
since Python 3.1 and with a warning since Python 3.11. Patch by Hugo van
Kemenade.