-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-105699: Add Some Stress Tests for Subinterpreter Creation #106966
Conversation
interp = interpreters.create() | ||
alive.append(interp) | ||
|
||
def test_create_many_threaded(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def test_create_many_threaded(self): | |
@requires_resource('cpu') | |
def test_create_many_threaded(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, what is the effect of this decorator? Also, what is it telling readers?
I wouldn't consider this test to be particularly CPU-intensive. We do spin up a couple hundred threads but not so many that this test should take more than a few seconds on a resource-starved host. Likewise, this shouldn't impose a significant memory burden. (Each interpreter uses ~3kB.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cpython/Lib/test/libregrtest/cmdline.py
Line 108 in cdeb1a6
cpu - Used for certain CPU-heavy tests. |
AFAIK, Conventionally, most CPU-intensive tests consume a few seconds in high-performance computers, we added the flag for low-performance CPUs to skip this test.
I thought that this test look quite CPU-intensive test, so I suggested adding it.
Left some minor suggestions. |
Thanks @ericsnowcurrently for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
GH-107012 is a backport of this pull request to the 3.12 branch. |
…ythonGH-106966) (cherry picked from commit adda43d) Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
|
The tests would have caught the crashes from gh-105699.