Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-105699: Add Some Stress Tests for Subinterpreter Creation #106966

Merged
merged 1 commit into from
Jul 22, 2023
Merged

gh-105699: Add Some Stress Tests for Subinterpreter Creation #106966

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions Lib/test/test_interpreters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

from test import support
from test.support import import_helper
from test.support import threading_helper
_interpreters = import_helper.import_module('_xxsubinterpreters')
_channels = import_helper.import_module('_xxinterpchannels')
from test.support import interpreters
Expand Down Expand Up @@ -463,6 +464,27 @@ def test_bytes_for_script(self):
# test_xxsubinterpreters covers the remaining Interpreter.run() behavior.


class StressTests(TestBase):

# In these tests we generally want a lot of interpreters,
# but not so many that any test takes too long.

def test_create_many_sequential(self):
corona10 marked this conversation as resolved.
Show resolved Hide resolved
alive = []
for _ in range(100):
interp = interpreters.create()
alive.append(interp)

def test_create_many_threaded(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def test_create_many_threaded(self):
@requires_resource('cpu')
def test_create_many_threaded(self):

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, what is the effect of this decorator? Also, what is it telling readers?

I wouldn't consider this test to be particularly CPU-intensive. We do spin up a couple hundred threads but not so many that this test should take more than a few seconds on a resource-starved host. Likewise, this shouldn't impose a significant memory burden. (Each interpreter uses ~3kB.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cpython/Lib/test/libregrtest/cmdline.py

Line 108 in cdeb1a6

cpu - Used for certain CPU-heavy tests.

AFAIK, Conventionally, most CPU-intensive tests consume a few seconds in high-performance computers, we added the flag for low-performance CPUs to skip this test.

I thought that this test look quite CPU-intensive test, so I suggested adding it.

alive = []
def task():
interp = interpreters.create()
alive.append(interp)
threads = (threading.Thread(target=task) for _ in range(200))
with threading_helper.start_threads(threads):
pass


class TestIsShareable(TestBase):

def test_default_shareables(self):
Expand Down