Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-115714: Don't use CLOCK_PROCESS_CPUTIME_ID and times() on WASI #115757

Merged
merged 2 commits into from
Feb 22, 2024
Merged

gh-115714: Don't use CLOCK_PROCESS_CPUTIME_ID and times() on WASI #115757

merged 2 commits into from
Feb 22, 2024

Conversation

encukou
Copy link
Member

@encukou encukou commented Feb 21, 2024 •
edited by bedevere-app bot
Loading

Either the results of these functions are too large, or sysconf(_SC_CLK_TCK) (_Py_GetTicksPerSecond) is too small.

wasi-libc is considering removing process time locks entirely: WebAssembly/wasi-libc#266

This removes them from Python's time early. time.process_time() falls back to clock():

>>> import time
>>> time.time(); time.process_time()
1708512528.3618634
14.538878902
>>> time.time(); time.process_time()
1708512529.045383
15.222434329
>>> time.get_clock_info('process_time')
namespace(implementation='clock()', monotonic=True, adjustable=False, resolution=1e-09)

@bedevere-app bedevere-app bot mentioned this pull request Feb 21, 2024
Closed
@encukou encukou merged commit 8aa372e into python:main Feb 22, 2024
35 checks passed
@encukou encukou deleted the wasi-no-process-time branch February 22, 2024 11:39
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@encukou @woodruffw
pythongh-115714: Don't use CLOCK_PROCESS_CPUTIME_ID and times() on WA…
9c68e3c 
…SI (pythonGH-115757)

* pythongh-115714: Don't use CLOCK_PROCESS_CPUTIME_ID and times() on WASI

* Add blurb
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@encukou @diegorusso
pythongh-115714: Don't use CLOCK_PROCESS_CPUTIME_ID and times() on WA…
7cea3d3 
…SI (pythonGH-115757)

* pythongh-115714: Don't use CLOCK_PROCESS_CPUTIME_ID and times() on WASI

* Add blurb
@hishamhm hishamhm mentioned this pull request Jul 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon brettcannon approved these changes

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@encukou @brettcannon